aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorOrgad Shaneh <[email protected]>2025-10-12 09:42:41 +0300
committerOrgad Shaneh <[email protected]>2025-10-13 10:32:02 +0000
commit495f8666c222a8bc02539415572e57ef855feeff (patch)
tree29cb81d9206e55a2331ec63a94d1892425327c7c
parentd3b1008e864e011b386e1d96869de8fcc33e7251 (diff)
QmlJSTools: Fix nodiscard warning with Qt 6.10
qmlformatsettings.cpp(151): warning C4834: discarding return value of function with [[nodiscard]] attribute Change-Id: I5505edfe11ff9622a577cb841b199bc70fac1ff1 Reviewed-by: Semih Yavuz <[email protected]>
-rw-r--r--src/plugins/qmljstools/qmlformatsettings.cpp31
1 files changed, 16 insertions, 15 deletions
diff --git a/src/plugins/qmljstools/qmlformatsettings.cpp b/src/plugins/qmljstools/qmlformatsettings.cpp
index 1951c747ed6..a8977e18787 100644
--- a/src/plugins/qmljstools/qmlformatsettings.cpp
+++ b/src/plugins/qmljstools/qmlformatsettings.cpp
@@ -148,26 +148,27 @@ QmlFormatProcess::QmlFormatProcess(const CommandLine &cmd)
: m_logFile("qmlformat.qtc.log")
{
m_logFile.setAutoRemove(false);
- m_logFile.open();
m_process.setCommand(cmd);
m_process.setWorkingDirectory(FilePath::fromString(m_tempDir.path()));
m_process.setProcessMode(ProcessMode::Writer);
- connect(&m_process, &Process::readyReadStandardOutput, [this] {
- const QString output = m_process.readAllStandardOutput();
- if (!output.isEmpty()) {
- qCInfo(qmlformatlog) << "qmlformat stdout is written to: " << m_logFile.filePath();
- QTextStream(&m_logFile) << "STDOUT: " << output << '\n';
- }
- });
- connect(&m_process, &Process::readyReadStandardError, [this] {
- const QString output = m_process.readAllStandardError();
- if (!output.isEmpty()) {
- qCInfo(qmlformatlog) << "qmlformat stderr is written to: " << m_logFile.filePath();
- QTextStream(&m_logFile) << "STDERR: " << output << '\n';
- }
- });
+ if (m_logFile.open()) {
+ connect(&m_process, &Process::readyReadStandardOutput, [this] {
+ const QString output = m_process.readAllStandardOutput();
+ if (!output.isEmpty()) {
+ qCInfo(qmlformatlog) << "qmlformat stdout is written to: " << m_logFile.filePath();
+ QTextStream(&m_logFile) << "STDOUT: " << output << '\n';
+ }
+ });
+ connect(&m_process, &Process::readyReadStandardError, [this] {
+ const QString output = m_process.readAllStandardError();
+ if (!output.isEmpty()) {
+ qCInfo(qmlformatlog) << "qmlformat stderr is written to: " << m_logFile.filePath();
+ QTextStream(&m_logFile) << "STDERR: " << output << '\n';
+ }
+ });
+ }
connect(&m_process, &Process::done, this, [this] {
ProcessResultData result = m_process.resultData();