Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(730)

Issue 1419693003: content: Make conversions from gfx::Point to PointF explicit. (Closed)

Created:
5 years, 2 months ago by danakj
Modified:
5 years, 2 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, kalyank, shuchen+watch_chromium.org, jam, yurys, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, dcheng, devtools-reviews_chromium.org, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, jdduke+watch_chromium.org, pfeldman, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

content: Make conversions from gfx::Point to PointF explicit. This implicit conversion operator will be going away. BUG=342848 Committed: https://crrev.com/2ef31b82eb2f3e8125fca800c291d9b437448614 Cr-Commit-Position: refs/heads/master@{#355343}

Patch Set 1 #

Total comments: 1

Patch Set 2 : pointfconvert-content: . #

Patch Set 3 : pointfconvert-content: . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -118 lines) Patch
M content/browser/devtools/protocol/input_handler.cc View 4 chunks +12 lines, -14 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl_unittest.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M content/browser/renderer_host/input/synthetic_gesture_controller_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/touch_action_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/touch_selection_controller_client_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 16 chunks +29 lines, -40 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura_browsertest.cc View 14 chunks +32 lines, -36 lines 0 comments Download
M content/common/input/synthetic_pinch_gesture_params.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/input/synthetic_smooth_drag_gesture_params.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/input/synthetic_smooth_scroll_gesture_params.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/input/synthetic_tap_gesture_params.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/input/input_handler_proxy.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_compositor_host.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M content/renderer/render_widget.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
danakj
https://codereview.chromium.org/1419693003/diff/1/content/renderer/render_widget.h File content/renderer/render_widget.h (right): https://codereview.chromium.org/1419693003/diff/1/content/renderer/render_widget.h#newcode769 content/renderer/render_widget.h:769: gfx::Point popup_view_origin_for_emulation_; Setters were setting integer points for these.
5 years, 2 months ago (2015-10-20 22:26:47 UTC) #2
no sievers
lgtm
5 years, 2 months ago (2015-10-21 16:55:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419693003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419693003/40001
5 years, 2 months ago (2015-10-21 18:03:18 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-21 18:18:10 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-21 18:19:30 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2ef31b82eb2f3e8125fca800c291d9b437448614
Cr-Commit-Position: refs/heads/master@{#355343}

Powered by Google App Engine
This is Rietveld 408576698