Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 6591091: Reverting the revert 76468. Removed include for browser_thread.h.... (Closed)

Created:
9 years, 9 months ago by ramant (doing other things)
Modified:
9 years, 7 months ago
CC:
chromium-reviews, Alexander Potapenko, Paweł Hajdan Jr., Timur Iskhodzhanov, pam+watch_chromium.org, brettw-cc_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Reverting the revert 76468. Removed include for browser_thread.h. Enable the WATCHDOG thread that monitors browser threads for their responsiveness using ping-pong messaging. WACTHDOG thread also collects statistics for response time for each thread via histograms. This CL was approved http://codereview.chromium.org/6588039 BUG=71378, 73915, 73844, 73975, 74029 TEST=performance tests TBR=jar Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76561

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+302 lines, -141 lines) Patch
M chrome/browser/browser_main.cc View 1 5 chunks +15 lines, -0 lines 0 comments Download
M chrome/browser/browser_process.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/browser_process_impl.h View 1 3 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 1 5 chunks +23 lines, -0 lines 0 comments Download
M chrome/browser/metrics/thread_watcher.h View 1 7 chunks +61 lines, -16 lines 0 comments Download
M chrome/browser/metrics/thread_watcher.cc View 1 13 chunks +146 lines, -60 lines 0 comments Download
M chrome/browser/metrics/thread_watcher_unittest.cc View 1 21 chunks +38 lines, -44 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/testing_browser_process.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/test/testing_browser_process.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M tools/valgrind/tsan/suppressions.txt View 1 2 chunks +0 lines, -21 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ramant (doing other things)
Hi Jim, It is exactly same as http://codereview.chromium.org/6588039. Changed include for browser_thread.h. thanks much, raman
9 years, 9 months ago (2011-03-02 01:31:20 UTC) #1
jar (doing other things)
9 years, 9 months ago (2011-03-02 06:17:54 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698