Use CREATE DATABASE ... STRATEGY = FILE_COPY in pg_upgrade.
authorNathan Bossart <[email protected]>
Mon, 8 Jul 2024 21:18:00 +0000 (16:18 -0500)
committerNathan Bossart <[email protected]>
Mon, 8 Jul 2024 21:18:00 +0000 (16:18 -0500)
commit64f34eb2e2ce4bca7351d8c88a6999aeed000c4a
tree957cf62a6c0ce41f49d84729da3ef8c9fbd3b09a
parent4b4b931bcdf23f5facd49809278a3048c4fdba1f
Use CREATE DATABASE ... STRATEGY = FILE_COPY in pg_upgrade.

While this strategy is ordinarily quite costly because it requires
performing two checkpoints, testing shows that it tends to be a
faster choice than WAL_LOG during pg_upgrade, presumably because
fsync is turned off.  Furthermore, we can skip the checkpoints
altogether because the problems they are intended to prevent don't
apply to pg_upgrade.  Instead, we just need to CHECKPOINT once in
the new cluster after making any changes to template0 and before
restoring the rest of the databases.  This ensures that said
template0 changes are written out to disk prior to creating the
databases via FILE_COPY.

Co-authored-by: Matthias van de Meent
Reviewed-by: Ranier Vilela, Dilip Kumar, Robert Haas, Michael Paquier
Discussion: https://postgr.es/m/Zl9ta3FtgdjizkJ5%40nathan
src/backend/commands/dbcommands.c
src/bin/pg_dump/pg_dump.c
src/bin/pg_upgrade/pg_upgrade.c