Add --no-sync to pg_upgrade's uses of pg_dump and pg_dumpall.
authorNathan Bossart <[email protected]>
Mon, 1 Jul 2024 15:18:26 +0000 (10:18 -0500)
committerNathan Bossart <[email protected]>
Mon, 1 Jul 2024 15:18:26 +0000 (10:18 -0500)
commit6e16b1e42003d811562d30b572ac3972238e2957
treec9d788526c1f8f072d8512c5fa937a6af9881612
parent3fb59e789dd9f21610101d1ec106ad58095e24f3
Add --no-sync to pg_upgrade's uses of pg_dump and pg_dumpall.

There's no reason to ensure that the files pg_upgrade generates
with pg_dump and pg_dumpall have been written safely to disk.  If
there is a crash during pg_upgrade, the upgrade must be restarted
from the beginning; dump files left behind by previous pg_upgrade
attempts cannot be reused.

Reviewed-by: Peter Eisentraut, Tom Lane, Michael Paquier, Daniel Gustafsson
Discussion: https://postgr.es/m/20240503171348.GA1731524%40nathanxps13
src/bin/pg_upgrade/dump.c