Make fast_fallback option false by default temporarily (#12070)

to suppress failing output in CI.

2 files changed, 58 insertions, 15 deletions

diff --git a/ext/socket/tcpsocket.c b/ext/socket/tcpsocket.c
index 3c03e89e0d..10b4810869 100644
--- a/ext/socket/tcpsocket.c
+++ b/ext/socket/tcpsocket.c
@@ -20,17 +20,14 @@
  *
  * Starting from Ruby 3.4, this method operates according to the
  * Happy Eyeballs Version 2 ({RFC 8305}[https://datatracker.ietf.org/doc/html/rfc8305])
- * algorithm by default, except on Windows.
- *
- * To make it behave the same as in Ruby 3.3 and earlier,
- * explicitly specify the option +fast_fallback:false+.
+ * algorithm with *fast_fallback:true+, except on Windows.
  *
  * Happy Eyeballs Version 2 is not provided on Windows,
  * and it behaves the same as in Ruby 3.3 and earlier.
  *
  * [:resolv_timeout] Specifies the timeout in seconds from when the hostname resolution starts.
  * [:connect_timeout] This method sequentially attempts connecting to all candidate destination addresses.<br>The +connect_timeout+ specifies the timeout in seconds from the start of the connection attempt to the last candidate.<br>By default, all connection attempts continue until the timeout occurs.<br>When +fast_fallback:false+ is explicitly specified,<br>a timeout is set for each connection attempt and any connection attempt that exceeds its timeout will be canceled.
- * [:fast_fallback] Enables the Happy Eyeballs Version 2 algorithm (enabled by default).
+ * [:fast_fallback] Enables the Happy Eyeballs Version 2 algorithm (disabled by default).
  *
  * === Happy Eyeballs Version 2
  * Happy Eyeballs Version 2 ({RFC 8305}[https://datatracker.ietf.org/doc/html/rfc8305])
@@ -60,7 +57,7 @@ tcp_init(int argc, VALUE *argv, VALUE sock)
     VALUE kwargs[4];
     VALUE resolv_timeout = Qnil;
     VALUE connect_timeout = Qnil;
-    VALUE fast_fallback = Qtrue;
+    VALUE fast_fallback = Qfalse;
     VALUE test_mode_settings = Qnil;
 
     if (!keyword_ids[0]) {
diff --git a/test/socket/test_tcp.rb b/test/socket/test_tcp.rb
index e9fee55f8f..b9d4f0b842 100644
--- a/test/socket/test_tcp.rb
+++ b/test/socket/test_tcp.rb
@@ -156,7 +156,12 @@ class TestSocket_TCPSocket < Test::Unit::TestCase
       server_thread = Thread.new { server.accept }
       port = server.addr[1]
 
-      socket = TCPSocket.new("localhost", port, test_mode_settings: { delay: { ipv4: 1000 } })
+      socket = TCPSocket.new(
+        "localhost",
+        port,
+        fast_fallback: true,
+        test_mode_settings: { delay: { ipv4: 1000 } }
+      )
       assert_true(socket.remote_address.ipv6?)
       server_thread.value.close
       server.close
@@ -174,7 +179,12 @@ class TestSocket_TCPSocket < Test::Unit::TestCase
       port = server.addr[1]
 
       server_thread = Thread.new { server.accept }
-      socket = TCPSocket.new("localhost", port, test_mode_settings: { delay: { ipv6: 1000 } })
+      socket = TCPSocket.new(
+        "localhost",
+        port,
+        fast_fallback: true,
+        test_mode_settings: { delay: { ipv6: 1000 } }
+      )
 
       assert_true(socket.remote_address.ipv4?)
       server_thread.value.close
@@ -199,7 +209,12 @@ class TestSocket_TCPSocket < Test::Unit::TestCase
       delay_time = 25 # Socket::RESOLUTION_DELAY (private) is 50ms
 
       server_thread = Thread.new { server.accept }
-      socket = TCPSocket.new("localhost", port, test_mode_settings: { delay: { ipv6: delay_time } })
+      socket = TCPSocket.new(
+        "localhost",
+        port,
+        fast_fallback: true,
+        test_mode_settings: { delay: { ipv6: delay_time } }
+      )
       assert_true(socket.remote_address.ipv6?)
       server_thread.value.close
       server.close
@@ -219,7 +234,12 @@ class TestSocket_TCPSocket < Test::Unit::TestCase
       port = ipv4_server.connect_address.ip_port
 
       ipv4_server_thread = Thread.new { ipv4_server.listen(1); ipv4_server.accept }
-      socket = TCPSocket.new("localhost", port, test_mode_settings: { delay: { ipv4: 10 } })
+      socket = TCPSocket.new(
+        "localhost",
+        port,
+        fast_fallback: true,
+        test_mode_settings: { delay: { ipv4: 10 } }
+      )
       assert_equal(ipv4_address, socket.remote_address.ip_address)
 
       accepted, _ = ipv4_server_thread.value
@@ -240,7 +260,12 @@ class TestSocket_TCPSocket < Test::Unit::TestCase
       port = ipv4_server.connect_address.ip_port
 
       ipv4_server_thread = Thread.new { ipv4_server.listen(1); ipv4_server.accept }
-      socket = TCPSocket.new("localhost", port, test_mode_settings: { delay: { ipv6: 25 } })
+      socket = TCPSocket.new(
+        "localhost",
+        port,
+        fast_fallback: true,
+        test_mode_settings: { delay: { ipv6: 25 } }
+      )
 
       assert_equal(
         socket.remote_address.ipv4?,
@@ -263,7 +288,12 @@ class TestSocket_TCPSocket < Test::Unit::TestCase
       port = server.addr[1]
 
       server_thread = Thread.new { server.accept }
-      socket = TCPSocket.new("localhost", port, test_mode_settings: { delay: { ipv4: 10 }, error: { ipv6: Socket::EAI_FAIL } })
+      socket = TCPSocket.new(
+        "localhost",
+        port,
+        fast_fallback: true,
+        test_mode_settings: { delay: { ipv4: 10 }, error: { ipv6: Socket::EAI_FAIL } }
+      )
 
       assert_true(socket.remote_address.ipv4?)
       server_thread.value.close
@@ -282,7 +312,13 @@ class TestSocket_TCPSocket < Test::Unit::TestCase
 
     begin;
       assert_raise(Errno::ETIMEDOUT) do
-        TCPSocket.new("localhost", port, resolv_timeout: 0.01, test_mode_settings: { delay: { ipv4: 1000 } })
+        TCPSocket.new(
+          "localhost",
+          port,
+          resolv_timeout: 0.01,
+          fast_fallback: true,
+          test_mode_settings: { delay: { ipv4: 1000 } }
+        )
       end
     end;
   end
@@ -301,7 +337,12 @@ class TestSocket_TCPSocket < Test::Unit::TestCase
 
     begin;
       assert_raise(Socket::ResolutionError) do
-        TCPSocket.new("localhost", port, test_mode_settings: { delay: { ipv4: 100 }, error: { ipv4: Socket::EAI_FAIL } })
+        TCPSocket.new(
+          "localhost",
+          port,
+          fast_fallback: true,
+          test_mode_settings: { delay: { ipv4: 100 }, error: { ipv4: Socket::EAI_FAIL } }
+        )
       end
     end;
   end
@@ -316,7 +357,12 @@ class TestSocket_TCPSocket < Test::Unit::TestCase
 
     begin;
       assert_raise(Errno::ECONNREFUSED) do
-        TCPSocket.new("localhost", port, test_mode_settings: { delay: { ipv4: 100 }, error: { ipv6: Socket::EAI_FAIL } })
+        TCPSocket.new(
+          "localhost",
+          port,
+          fast_fallback: true,
+          test_mode_settings: { delay: { ipv4: 100 }, error: { ipv6: Socket::EAI_FAIL } }
+        )
       end
     end;
   end