summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMasataka Pocke Kuwabara <[email protected]>2020-07-10 07:01:10 +0900
committerGitHub <[email protected]>2020-07-09 15:01:10 -0700
commitba81bc24e62d03cc0f4c05cf4e2b378696631568 (patch)
tree0466e8eb5b4f3b013109ad827691688308623ae7
parent7a479b30b647c38ded91e45c9e8e22d30b671e07 (diff)
Add instance_methods to class generated by DelegateClass
Also, make DelegateClass.instance_method fallback to superclass. Fixes [Bug #16982]
Notes
Notes: Merged: https://github.com/ruby/ruby/pull/3221 Merged-By: jeremyevans <[email protected]>
-rw-r--r--lib/delegate.rb15
-rw-r--r--test/test_delegate.rb34
2 files changed, 49 insertions, 0 deletions
diff --git a/lib/delegate.rb b/lib/delegate.rb
index d6fb90bdbf..a1fded6425 100644
--- a/lib/delegate.rb
+++ b/lib/delegate.rb
@@ -422,6 +422,21 @@ def DelegateClass(superclass, &block)
klass.define_singleton_method :protected_instance_methods do |all=true|
super(all) | superclass.protected_instance_methods
end
+ klass.define_singleton_method :instance_methods do |all=true|
+ super(all) | superclass.instance_methods
+ end
+ klass.define_singleton_method :public_instance_method do |name|
+ super(name)
+ rescue NameError
+ raise unless self.public_instance_methods.include?(name)
+ superclass.public_instance_method(name)
+ end
+ klass.define_singleton_method :instance_method do |name|
+ super(name)
+ rescue NameError
+ raise unless self.instance_methods.include?(name)
+ superclass.instance_method(name)
+ end
klass.module_eval(&block) if block
return klass
end
diff --git a/test/test_delegate.rb b/test/test_delegate.rb
index 4a3445f121..57480b18ea 100644
--- a/test/test_delegate.rb
+++ b/test/test_delegate.rb
@@ -106,6 +106,10 @@ class TestDelegateClass < Test::Unit::TestCase
protected
def parent_protected; end
+
+ private
+
+ def parent_private; end
end
class Child < DelegateClass(Parent)
@@ -117,6 +121,10 @@ class TestDelegateClass < Test::Unit::TestCase
protected
def parent_protected_added; end
+
+ private
+
+ def parent_private_added; end
end
def test_public_instance_methods
@@ -131,6 +139,32 @@ class TestDelegateClass < Test::Unit::TestCase
assert_equal([:parent_protected, :parent_protected_added], (Child.new(Parent.new).protected_methods - ignores).sort)
end
+ def test_instance_methods
+ ignores = Object.instance_methods | Delegator.instance_methods
+ assert_equal([:parent_protected, :parent_protected_added, :parent_public, :parent_public_added], (Child.instance_methods - ignores).sort)
+ assert_equal([:parent_protected, :parent_protected_added, :parent_public, :parent_public_added], (Child.new(Parent.new).methods - ignores).sort)
+ end
+
+ def test_DelegateClass_instance_method
+ assert_instance_of UnboundMethod, Child.instance_method(:parent_public)
+ assert_instance_of UnboundMethod, Child.instance_method(:parent_public_added)
+ assert_instance_of UnboundMethod, Child.instance_method(:parent_protected)
+ assert_instance_of UnboundMethod, Child.instance_method(:parent_protected_added)
+ assert_raise(NameError) { Child.instance_method(:parent_private) }
+ assert_raise(NameError) { Child.instance_method(:parent_private_added) }
+ assert_instance_of UnboundMethod, Child.instance_method(:to_s)
+ end
+
+ def test_DelegateClass_public_instance_method
+ assert_instance_of UnboundMethod, Child.public_instance_method(:parent_public)
+ assert_instance_of UnboundMethod, Child.public_instance_method(:parent_public_added)
+ assert_raise(NameError) { Child.public_instance_method(:parent_protected) }
+ assert_raise(NameError) { Child.public_instance_method(:parent_protected_added) }
+ assert_raise(NameError) { Child.instance_method(:parent_private) }
+ assert_raise(NameError) { Child.instance_method(:parent_private_added) }
+ assert_instance_of UnboundMethod, Child.public_instance_method(:to_s)
+ end
+
class IV < DelegateClass(Integer)
attr_accessor :var