Skip to content

Increase test coverage for OpenAIAsyncClient and OpenAIClient#44678

Merged
mssfang merged 30 commits intoAzure:mainfrom
markmunozmsft:us/open-ai-async-client
Apr 16, 2025
Merged

Increase test coverage for OpenAIAsyncClient and OpenAIClient#44678
mssfang merged 30 commits intoAzure:mainfrom
markmunozmsft:us/open-ai-async-client

Conversation

@v-cristhianh
Copy link
Copy Markdown
Contributor

@v-cristhianh v-cristhianh commented Mar 17, 2025

Description

Test coverage for the file OpenAIAsyncClient.java has increased from 81% to 87%:
image
Also increased from 80% to 87% the file OpenAIClient.java:
image
Theses changes can be verified in the JaCoCo report after running mvn clean install.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. OpenAI labels Mar 17, 2025
@github-actions
Copy link
Copy Markdown
Contributor

Thank you for your contribution @v-cristhianh! We will review the pull request and get back to you soon.

@v-cristhianh v-cristhianh force-pushed the us/open-ai-async-client branch 2 times, most recently from fa8bd5e to ad22d77 Compare March 18, 2025 19:16
@azure-sdk
Copy link
Copy Markdown
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

com.azure:azure-ai-openai

@v-cristhianh v-cristhianh force-pushed the us/open-ai-async-client branch from fed63f0 to 8a90ce6 Compare March 20, 2025 13:54
@v-cristhianh v-cristhianh requested a review from jpalvarezl March 20, 2025 19:46
@v-cristhianh v-cristhianh force-pushed the us/open-ai-async-client branch from 7daaef2 to 0a32c49 Compare March 25, 2025 12:38
@v-cristhianh v-cristhianh requested a review from jpalvarezl March 25, 2025 20:51
@v-cristhianh v-cristhianh changed the title Us/open ai async client Increase test coverage for OpenAIAsyncClient Mar 25, 2025
@v-cristhianh v-cristhianh force-pushed the us/open-ai-async-client branch from 2c8c75e to 82cae6d Compare March 27, 2025 14:27
Copy link
Copy Markdown
Member

@jpalvarezl jpalvarezl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good. Thank you! Once you write the sync version of these tests and then add a copy to the NonAzureOpenAIAsyncClientTest (you pretty much just need to copy and paste everything you've just done, except you need to change the method you use for initializing client in the test.

@v-cristhianh v-cristhianh force-pushed the us/open-ai-async-client branch from 82cae6d to c71308c Compare April 2, 2025 15:17
@v-cristhianh v-cristhianh changed the title Increase test coverage for OpenAIAsyncClient Increase test coverage for OpenAIAsyncClient and OpenAIClient Apr 2, 2025
@v-cristhianh v-cristhianh requested a review from jpalvarezl April 4, 2025 11:39
@v-cristhianh v-cristhianh force-pushed the us/open-ai-async-client branch 2 times, most recently from fb3797c to 39bdf39 Compare April 7, 2025 12:41
@v-cristhianh v-cristhianh force-pushed the us/open-ai-async-client branch from 39bdf39 to 0ea35f1 Compare April 14, 2025 16:42
Copy link
Copy Markdown
Member

@jpalvarezl jpalvarezl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am seeing issues with these tests being run in LIVE. Just to name a couple:

  • Non Azure OpenAI tests should use, i.e. getAudioTranslationRunnerForNonAzure instead of getAudioTranslationRunner (model/deployment names are different)
  • Non Azure OpenAI has different error codes. 404 -> 400 or the other way around.
  • There style check issues that would be solved if you run mvn clean install locally.

@v-cristhianh v-cristhianh requested a review from jpalvarezl April 15, 2025 12:04
Copy link
Copy Markdown
Member

@jpalvarezl jpalvarezl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed the new recordings, however I had to remove the tests for using StreamOptions as they were still failing.

I think there could be a model compatibility issue. Let's punt those to a separate PR.

@jpalvarezl jpalvarezl marked this pull request as ready for review April 16, 2025 08:35
@v-cristhianh
Copy link
Copy Markdown
Contributor Author

v-cristhianh commented Apr 16, 2025

@v-cristhianh please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”), and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your contributions to Microsoft open source projects. This Agreement is effective as of the latest signature date below.

  1. Definitions.
    “Code” means the computer software code, whether in human-readable or machine-executable form,
    that is delivered by You to Microsoft under this Agreement.
    “Project” means any of the projects owned or managed by Microsoft and offered under a license
    approved by the Open Source Initiative (www.opensource.org).
    “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
    Project, including but not limited to communication on electronic mailing lists, source code control
    systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
    discussing and improving that Project, but excluding communication that is conspicuously marked or
    otherwise designated in writing by You as “Not a Submission.”
    “Submission” means the Code and any other copyrightable material Submitted by You, including any
    associated comments and documentation.
  2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
    Project. This Agreement covers any and all Submissions that You, now or in the future (except as
    described in Section 4 below), Submit to any Project.
  3. Originality of Work. You represent that each of Your Submissions is entirely Your original work.
    Should You wish to Submit materials that are not Your original work, You may Submit them separately
    to the Project if You (a) retain all copyright and license information that was in the materials as You
    received them, (b) in the description accompanying Your Submission, include the phrase “Submission
    containing materials of a third party:” followed by the names of the third party and any licenses or other
    restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
    guidelines concerning Submissions.
  4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
    for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
    Submission is made in the course of Your work for an employer or Your employer has intellectual
    property rights in Your Submission by contract or applicable law, You must secure permission from Your
    employer to make the Submission before signing this Agreement. In that case, the term “You” in this
    Agreement will refer to You and the employer collectively. If You change employers in the future and
    desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
    and secure permission from the new employer before Submitting those Submissions.
  5. Licenses.
  • Copyright License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
    Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
    the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
    parties.
  • Patent License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
    Your patent claims that are necessarily infringed by the Submission or the combination of the
    Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
    import or otherwise dispose of the Submission alone or with the Project.
  • Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
    No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
    granted by implication, exhaustion, estoppel or otherwise.
  1. Representations and Warranties. You represent that You are legally entitled to grant the above
    licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
    have disclosed under Section 3). You represent that You have secured permission from Your employer to
    make the Submission in cases where Your Submission is made in the course of Your work for Your
    employer or Your employer has intellectual property rights in Your Submission by contract or applicable
    law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
    have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
    You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
    REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
    EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
    PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
    NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
  2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
    You later become aware that would make Your representations in this Agreement inaccurate in any
    respect.
  3. Information about Submissions. You agree that contributions to Projects and information about
    contributions may be maintained indefinitely and disclosed publicly, including Your name and other
    information that You submit with Your Submission.
  4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
    the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
    Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
    exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
    defenses of lack of personal jurisdiction and forum non-conveniens.
  5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
    supersedes any and all prior agreements, understandings or communications, written or oral, between
    the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

@microsoft-github-policy-service agree company="Aditi Consulting LLC"

@jpalvarezl jpalvarezl enabled auto-merge (squash) April 16, 2025 14:20
@mssfang mssfang disabled auto-merge April 16, 2025 17:48
@mssfang mssfang enabled auto-merge (squash) April 16, 2025 17:49
@mssfang
Copy link
Copy Markdown
Contributor

mssfang commented Apr 16, 2025

/check-enforcer override

@mssfang mssfang merged commit a07de80 into Azure:main Apr 16, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. OpenAI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants