-
Notifications
You must be signed in to change notification settings - Fork 41
[#144] Fix typo: "Recurrencies" -> "Recurrences" #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ok, good to go. |
@Bodigrim this isn't as trivial as the PR from earlier today that only fixes documentation, but please go over it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is better to do it other way around: put actual code in *Recurrences*
and re-export it from deprecated *Recurrencies*
modules. In this case we will just purge *Recurrencies*
in future releases, without moving any chunks of code.
@@ -0,0 +1,14 @@ | |||
-- | | |||
-- Module: Math.NumberTheory.Recurrences.Pentagonal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Module name is wrong.
@@ -0,0 +1,14 @@ | |||
-- | | |||
-- Module: Math.NumberTheory.Recurrences.Pentagonal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Module name is wrong.
@Bodigrim that does sound better, I didn't consider doing it that way. I'll refactor things, then. |
... `Math.NumberTheory.Recurrences.Bilinear`
... `Math.NumberTheory.Recurrences.Linear`
... `Math.NumberTheory.Recurrences.Pentagonal`
@Bodigrim good to go. |
Thanks! |
Closes #144.
Still WIP.