Skip to content

[#144] Fix typo: "Recurrencies" -> "Recurrences" #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 3, 2018

Conversation

rockbmb
Copy link
Contributor

@rockbmb rockbmb commented Oct 1, 2018

Closes #144. Still WIP.

@rockbmb
Copy link
Contributor Author

rockbmb commented Oct 1, 2018

Ok, good to go.

@rockbmb
Copy link
Contributor Author

rockbmb commented Oct 1, 2018

@Bodigrim this isn't as trivial as the PR from earlier today that only fixes documentation, but please go over it.

Copy link
Owner

@Bodigrim Bodigrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better to do it other way around: put actual code in *Recurrences* and re-export it from deprecated *Recurrencies* modules. In this case we will just purge *Recurrencies* in future releases, without moving any chunks of code.

@@ -0,0 +1,14 @@
-- |
-- Module: Math.NumberTheory.Recurrences.Pentagonal
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Module name is wrong.

@@ -0,0 +1,14 @@
-- |
-- Module: Math.NumberTheory.Recurrences.Pentagonal
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Module name is wrong.

@rockbmb
Copy link
Contributor Author

rockbmb commented Oct 2, 2018

@Bodigrim that does sound better, I didn't consider doing it that way. I'll refactor things, then.

@rockbmb rockbmb changed the title [#144] Fix typo in benchmark and test modules [#144] Fix typo: "Recurrencies" -> "Recurrences" Oct 2, 2018
@rockbmb
Copy link
Contributor Author

rockbmb commented Oct 2, 2018

@Bodigrim good to go.

@Bodigrim Bodigrim merged commit 8b925d2 into Bodigrim:master Oct 3, 2018
@Bodigrim
Copy link
Owner

Bodigrim commented Oct 3, 2018

Thanks!

@rockbmb rockbmb deleted the fix-recurrences-typo branch October 3, 2018 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants