Skip to content

Conversation

@bertrandda
Copy link
Contributor

@bertrandda bertrandda commented Jun 29, 2025

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

Handle shutter with only state feature by emulating position and target position in Homekit

@codecov
Copy link

codecov bot commented Jun 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.65%. Comparing base (f9f893a) to head (29a98bf).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2342   +/-   ##
=======================================
  Coverage   98.65%   98.65%           
=======================================
  Files         903      903           
  Lines       15361    15368    +7     
=======================================
+ Hits        15154    15161    +7     
  Misses        207      207           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@relativeci
Copy link

relativeci bot commented Jun 29, 2025

#3448 Bundle Size — 10.93MiB (0%).

29a98bf(current) vs f9f893a master#3431(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  no changes
                 Current
#3448
     Baseline
#3431
No change  Initial JS 6.04MiB 6.04MiB
No change  Initial CSS 305.82KiB 305.82KiB
Change  Cache Invalidation 0% 55.15%
No change  Chunks 51 51
No change  Assets 174 174
No change  Modules 1607 1607
No change  Duplicate Modules 21 21
No change  Duplicate Code 0.94% 0.94%
No change  Packages 136 136
No change  Duplicate Packages 2 2
Bundle size by type  no changes
                 Current
#3448
     Baseline
#3431
No change  JS 7.93MiB 7.93MiB
No change  IMG 2.57MiB 2.57MiB
No change  CSS 323.67KiB 323.67KiB
No change  Fonts 93.55KiB 93.55KiB
No change  Other 18.38KiB 18.38KiB
No change  HTML 13.58KiB 13.58KiB

Bundle analysis reportBranch bertrandda:fix/hk-shutter-state-...Project dashboard


Generated by RelativeCIDocumentationReport issue

@bertrandda bertrandda changed the title [WIP] Handle state only shutter in Homekit Handle state only shutter in Homekit Jul 4, 2025
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! :)

@Pierre-Gilles Pierre-Gilles merged commit 647d4d8 into GladysAssistant:master Jul 11, 2025
9 checks passed
@bertrandda bertrandda deleted the fix/hk-shutter-state-only branch July 11, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants