Skip to content

Added Events for Cloud Run for Anthos samples. Fixes #3330 #3331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2020
Merged

Added Events for Cloud Run for Anthos samples. Fixes #3330 #3331

merged 1 commit into from
Jul 10, 2020

Conversation

meteatamel
Copy link
Contributor

Fixes #issue

It's a good idea to open an issue first for discussion.

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • API's need to be enabled to test (tell us)
  • Environment Variables need to be set (ask us to set them)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • Please merge this PR for me once it is approved.

@meteatamel meteatamel requested a review from a team July 10, 2020 15:37
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 10, 2020
lesv
lesv approved these changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm presuming you've established anthos.md as a standard already. If not, please consider anthos-README.md

@averikitsch averikitsch merged commit d3ef899 into GoogleCloudPlatform:master Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesv lesv lesv approved these changes

@averikitsch averikitsch averikitsch approved these changes

Assignees

@dzlier-gcp dzlier-gcp

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@meteatamel @lesv @averikitsch @googlebot @dzlier-gcp