Skip to content

Move AUTH_* constans to dedicated class #955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
acrobat opened this issue Dec 20, 2020 · 1 comment · Fixed by #1036
Closed

Move AUTH_* constans to dedicated class #955

acrobat opened this issue Dec 20, 2020 · 1 comment · Fixed by #1036
Labels
good first issue Ideal for your first contribution!

Comments

@acrobat
Copy link
Collaborator

acrobat commented Dec 20, 2020

Deprecate the AUTH_ constants in the Client class and move them to a dedicated AuthMethods class.
@acrobat acrobat added the good first issue Ideal for your first contribution! label Dec 20, 2020
@acrobat acrobat mentioned this issue Dec 20, 2020
Merged
ipalo added a commit to ipalo/php-github-api that referenced this issue Oct 30, 2021
@ipalo
refs KnpLabs#955: deprecate Client::AUTH_* constants and replace them…
11c2d9f 
… with AuthMethod::AUTH_* const
@ipalo ipalo mentioned this issue Oct 30, 2021
Merged
@ipalo
Copy link
Contributor

ipalo commented Oct 30, 2021

I'm working on it, let me know your comment on my PR 🖖

ipalo added a commit to ipalo/php-github-api that referenced this issue Oct 30, 2021
@ipalo
refs KnpLabs#955: revert the Client::AUTH_* deletion (BC)
f4774d0
ipalo added a commit to ipalo/php-github-api that referenced this issue Oct 31, 2021
@ipalo
refs KnpLabs#955: fix CR issues
e7f1ab9
ipalo added a commit to ipalo/php-github-api that referenced this issue Oct 31, 2021
@ipalo
refs KnpLabs#955: add upgrade to v4.0 notes
c9cf54e
@acrobat acrobat linked a pull request Oct 31, 2021 that will close this issue
refs #955: deprecate Client::AUTH_* constants and replace them with AuthMethod::AUTH_* const #1036
Merged
ipalo added a commit to ipalo/php-github-api that referenced this issue Nov 1, 2021
@ipalo
refs KnpLabs#955: set public all constants
ec6656c
acrobat pushed a commit that referenced this issue Nov 2, 2021
@ipalo
feature #1036 refs #955: deprecate Client::AUTH_* constants and repla…
de2f278 
…ce them with AuthMethod::AUTH_* const (ipalo)

This PR was squashed before being merged into the 3.4.x-dev branch.

Discussion
----------

Contribution for #955

Commits
-------

11c2d9f refs #955: deprecate Client::AUTH_* constants and replace them with AuthMethod::AUTH_* const
f4774d0 refs #955: revert the Client::AUTH_* deletion (BC)
e7f1ab9 refs #955: fix CR issues
c9cf54e refs #955: add upgrade to v4.0 notes
ec6656c refs #955: set public all constants
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Ideal for your first contribution!
Projects
None yet
Milestone
No milestone
2 participants
@ipalo @acrobat