Skip to content

Raise minimum VS Code API version to 1.51 (to match LSP minimum) #15237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jakebailey opened this issue Jan 26, 2021 · 0 comments
Closed

Raise minimum VS Code API version to 1.51 (to match LSP minimum) #15237

jakebailey opened this issue Jan 26, 2021 · 0 comments
Assignees
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. debt Covers everything internal: CI, testing, refactoring of the codebase, etc.

Comments

@jakebailey
Copy link
Member

Through some recent reports and stack traces, I've noticed that the LSP client enforces its own (sort of undocumented) minimum VS Code API version (see: https://github.com/microsoft/vscode-languageserver-node/blob/20681d7632bb129def0c751be73cf76bd01f2f3a/client/src/node/main.ts#L25). This results in crashes when someone's using an LS but a version below their minimum.

Right now, the client we use (which is a prerelease) has a minimum of 1.51 to start a client. I think it might be a good idea to boost the required version up to that level to prevent oddities. Eventually, it'll be somewhat required when jedi is behind an LS.

Eventually, I'll want to bump the LSP library to the latest stable, but that bumps the minimum to 1.52.

Some examples:

@jakebailey jakebailey added the triage-needed Needs assignment to the proper sub-team label Jan 26, 2021
@karthiknadig karthiknadig added area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Jan 27, 2021
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Jan 27, 2021
@luabud luabud closed this as completed Feb 18, 2021
@ghost ghost removed the needs PR label Feb 18, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Development

No branches or pull requests

3 participants