Skip to content

Conversation

@Grinnz
Copy link
Contributor

@Grinnz Grinnz commented Dec 27, 2019

Updated links in pod and some other references. Link to illguts (https://search.cpan.org/dist/illguts/) not changed because there isn't a good way to link directly to it on metacpan.

@jkeenan
Copy link
Contributor

jkeenan commented Dec 28, 2019

When I ran this through make test_porting, I got this failure:

$ cd t;./perl harness porting/customized.t; cd -
porting/customized.t .. 1/? # Failed test 7 - SHA for pod/perlfilter.pod matches stashed SHA at porting/customized.t line 112
#      got "2d98239c4f4a930ad165444c3879629bb91f4cef"
# expected "e9833bf4ebc51087dfee5c553e0f8a5eef67212d"
porting/customized.t .. Failed 1/31 subtests 

Test Summary Report
-------------------
porting/customized.t (Wstat: 0 Tests: 31 Failed: 1)
  Failed test:  7
Files=1, Tests=31,  0 wallclock secs ( 0.01 usr  0.01 sys +  0.04 cusr  0.00 csys =  0.06 CPU)
Result: FAIL

Can you investigate?

Thank you very much.
Jim Keenan

@Grinnz
Copy link
Contributor Author

Grinnz commented Jan 9, 2020

I assume this is because of the change to perlfilter.pod? Is there a way I should fix it, should I just shasum the new file?

@tonycoz
Copy link
Contributor

tonycoz commented Jan 9, 2020

I assume this is because of the change to perlfilter.pod? Is there a way I should fix it, should I just shasum the new file?

pod/perlfilter.pod is maintained upstream in RURBAN/Filter, but you're not the first one to modify it without sending the changes upstream.

You can regenerate the hashes with:

./perl t/porting/customized.t -regen

@Grinnz Grinnz force-pushed the search_cpan_to_metacpan branch from 68d4e3c to c907f5e Compare January 13, 2020 22:17
@Grinnz
Copy link
Contributor Author

Grinnz commented Jan 13, 2020

I removed the change to perlfilter.pod - I can send it upstream.

@tonycoz tonycoz merged commit c23f766 into Perl:blead Jan 21, 2020
@Grinnz Grinnz deleted the search_cpan_to_metacpan branch January 21, 2020 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants