Skip to content

Clean out most of mathoms.c #22714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Nov 17, 2024
Merged

Clean out most of mathoms.c #22714

merged 13 commits into from
Nov 17, 2024

Conversation

khwilliamson
Copy link
Contributor

#22691 enabled macros to easily mimic functions. This commit takes advantage of that to remove most of mathoms.c. Macros use fewer resources than stub function calls

  • I don't know if this set of changes requires a perldelta entry

@khwilliamson khwilliamson force-pushed the rm_mp branch 2 times, most recently from 9f42e68 to 7027323 Compare October 30, 2024 19:41
mauke
mauke reviewed Nov 7, 2024
View reviewed changes
@khwilliamson
Move Perl_hv_* mathoms functions to macros in hv.h
f3df6ef
@khwilliamson
Move Perl_gv_* mathoms function to macros in gv.h
308cbd4
@khwilliamson
Move many SV mathoms functions to macros in sv.h
c4df034
@khwilliamson
Move Perl_ref(), Perl_sv_unref() from mathoms to macros
8bef5ef 
in op.h and sv.h respectively
@khwilliamson
Move Perl_do_open from mathoms to macro in perl.h
54e8305
@khwilliamson
Move Perl_do_aexec from mathoms to macro in perl.h
23285c0
@khwilliamson
Move Perl_newAV() from mathoms to av.h
47f3937
@khwilliamson
Mv all Perl_save* functions from mathoms to macros
da099c6 
into scope.h
@khwilliamson
Move Perl_newIO() from mathoms to macro in sv.h
08bc802
@khwilliamson
Move Perl_newSUB() from mathoms to macro in op.h
90a8345
@khwilliamson
Move Perl_l?stat() from mathoms to macros in perl.h
66f490f
@khwilliamson
Move Perl_is_utf8_char_buf from mathoms to be a macro is utf8.h
2ab2074
@khwilliamson
av.h Remove obsolete comment
33df29a 
See Perl#22714 (review)
@khwilliamson khwilliamson merged commit 0ac9cc0 into Perl:blead Nov 17, 2024
scottchiefbaker pushed a commit to scottchiefbaker/perl5 that referenced this pull request Nov 21, 2024
@khwilliamson @scottchiefbaker
av.h Remove obsolete comment
d800fe9 
See Perl#22714 (review)
scottchiefbaker pushed a commit to scottchiefbaker/perl5 that referenced this pull request Nov 21, 2024
@khwilliamson @scottchiefbaker
av.h Remove obsolete comment
6bd7a70 
See Perl#22714 (review)
@khwilliamson khwilliamson deleted the rm_mp branch April 23, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauke mauke mauke left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khwilliamson @mauke