No need to populate profile when creating a command executor, it uses capabilities just to recognize legacy mode

barancev · barancev · commit af65fc1eb13d · 2017-01-07T23:32:34.000+03:00
diff --git a/java/client/src/org/openqa/selenium/firefox/FirefoxDriver.java b/java/client/src/org/openqa/selenium/firefox/FirefoxDriver.java
@@ -250,7 +250,7 @@ public FirefoxDriver(FirefoxBinary binary, FirefoxProfile profile, Capabilities
 
   public FirefoxDriver(FirefoxBinary binary, FirefoxProfile profile,
       Capabilities desiredCapabilities, Capabilities requiredCapabilities) {
-    this(createCommandExecutor(populateProfile(profile, desiredCapabilities), binary, profile),
+    this(createCommandExecutor(desiredCapabilities, binary, profile),
          populateProfile(profile, desiredCapabilities), requiredCapabilities);
     this.binary = binary;
   }

Original file line number	Diff line number	Diff line change
`@@ -250,7 +250,7 @@ public FirefoxDriver(FirefoxBinary binary, FirefoxProfile profile, Capabilities`
`250`	`250`
`251`	`251`	`public FirefoxDriver(FirefoxBinary binary, FirefoxProfile profile,`
`252`	`252`	`Capabilities desiredCapabilities, Capabilities requiredCapabilities) {`
`253`		`- this(createCommandExecutor(populateProfile(profile, desiredCapabilities), binary, profile),`
	`253`	`+ this(createCommandExecutor(desiredCapabilities, binary, profile),`
`254`	`254`	`populateProfile(profile, desiredCapabilities), requiredCapabilities);`
`255`	`255`	`this.binary = binary;`
`256`	`256`	`}`