Skip to content

netty doesn't send authorization header, okhttp does #8005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jsa34 opened this issue Feb 6, 2020 · 2 comments
Closed

netty doesn't send authorization header, okhttp does #8005

jsa34 opened this issue Feb 6, 2020 · 2 comments
Labels
B-grid Everything grid and server related C-java Java Bindings

Comments

@jsa34
Copy link

jsa34 commented Feb 6, 2020

💥 Regression Report

A clear and concise description of what the regression is.

Last working Selenium version

Worked up to version: 4.0.0-alpha-3

Stopped working in version: 4.0.0-alpha-4

To Reproduce

Sending requests to GGR requires the Authorization header to be set, but the netty implementation doesn't seem to set this, unlike the okhttp implementation. See aerokube/ggr#301

Stopped working in alpha-4 as the default is now the netty implementation, and if I override the system prop to use okhttp, all is well again!

Detailed steps to reproduce the behavior:

Expected behavior

A clear and concise description of what you expected to happen.

Netty implementation sends authorization header as okhttp currently does.

@ghost ghost added the A-needs-triaging A Selenium member will evaluate this soon! label Feb 6, 2020
@vania-pooh
Copy link
Contributor

I would say this is not Ggr-specific issue. Cloud providers also use the same basic HTTP authentication mechanism. So this potentially breaks working with cloud providers too.

@AutomatedTester AutomatedTester added B-grid Everything grid and server related C-java Java Bindings and removed A-needs-triaging A Selenium member will evaluate this soon! labels Mar 5, 2020
@lock
Copy link

lock bot commented Apr 15, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
B-grid Everything grid and server related C-java Java Bindings
Projects
None yet
Development

No branches or pull requests

3 participants