Skip to content

[rust] Selenium-Manager fails when a browser detection fails with browser version (#11382) #11399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

bonigarcia
Copy link
Member

Description

When a browser version is specified in Selenium Manager (using --browser-version), for instance, an unstable version (e.g., beta, dev, or canary/nightly), instead of falling back to the latest driver, Selenium Manager should raise an error.

Motivation and Context

This PR implements #11382.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bonigarcia bonigarcia merged commit f7cf7c7 into trunk Dec 12, 2022
@bonigarcia bonigarcia deleted the se_mgr_error_version_detection branch December 12, 2022 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants