Skip to content

[dotnet] Declare selenium manager binaries as content #12711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

nvborisenko
Copy link
Member

Description

It allows selenium manager to be included into installers, like msi/exe or vsto.

Motivation and Context

Fixes #12577

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Sigrec
Copy link

Sigrec commented Sep 11, 2023

Not sure if this is the best place to ask but, is there a nightly build for this?

@titusfortner
Copy link
Member

No, but we'd like to. I think nuget supports them. @diemol did we look into this? Are we limited by bazel?

@diemol
Copy link
Member

diemol commented Sep 11, 2023

@nvborisenko said they need to be pushed with a beta suffix or something like that. I don't think bazel is blocking us. We are just very short on time.

@nvborisenko nvborisenko added this to the 4.13 milestone Sep 14, 2023
@titusfortner titusfortner merged commit 61fe50b into SeleniumHQ:trunk Sep 15, 2023
@nvborisenko nvborisenko deleted the dotnet-vsto-pack branch September 15, 2023 19:00
@Sigrec
Copy link

Sigrec commented Sep 29, 2023

Follow up to this fix, how can I change where the web driver looks for selenium-manager to the self-contained executable itself (ClickOnce), as it still checks the current working directory path where the .exe resides? Or maybe I'm just doing something wrong or missing something.

@nvborisenko
Copy link
Member Author

Selenium manager should be inside of your ClickOnce app, and it should be unpacked when you deploy/install your app. Thus you don't care about selenium manager location, it should just work.

If it doesn't, please create new issue.

@Sigrec
Copy link

Sigrec commented Sep 29, 2023

Issue created #12842 found out the issue is when publishing to a single file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Unable to obtain MicrosoftEdge using Selenium Manager
4 participants