[rb]Fix W3C patterns #4644
Closed
[rb]Fix W3C patterns #4644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @barancev, could we release new ruby binding if this PR is approved? Thanks! |
|
Thank you for the contribution! I've removed platformVersion from capabilities, however, other capabilities should have been kept which is why I haven't merged your PR. Once CI passes, I'll make a patch release for selenium-webdriver gem. |
|
Fixed in 3.5.2. |
Tom-Trumper
pushed a commit
to Tom-Trumper/selenium
that referenced
this pull request
Sep 11, 2017
topherbullock
pushed a commit
to topherbullock/selenium
that referenced
this pull request
Oct 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xin the preceding checkbox, I verify that I have signed the Contributor License AgreementPR- #4641
Spec - https://www.w3.org/TR/webdriver/#capabilities