fix unable to disable native events on IE driver version 3.4+ issue#6183
Merged
shs96c merged 1 commit intoSeleniumHQ:masterfrom Jul 24, 2018
KentGu:master_add_native_events
Merged
fix unable to disable native events on IE driver version 3.4+ issue#6183shs96c merged 1 commit intoSeleniumHQ:masterfrom KentGu:master_add_native_events
shs96c merged 1 commit intoSeleniumHQ:masterfrom
KentGu:master_add_native_events
Conversation
Add disable native events function as the native event for ie is enabled by default
Member
|
@KentGu, thank you for this! Not quite sure how we missed this, but it's a great catch. Can you please confirm that you've signed the Contributor License Agreement? Once you do, I'll happily merge this in. |
Member
|
Don't we have a test for this case? Is it worth to add one? |
Contributor
Author
Member
|
@KentGu we need you to sign the Contributor License Agreement before we can merge your code. The checkbox just signifies that you have done this step. |
Contributor
Author
|
@lmtierney Thanks for your help. I've signed the agreement just now |
Member
grigaman
pushed a commit
to grigaman/selenium
that referenced
this pull request
Sep 20, 2018
Add disable native events function as the native event for ie is enabled by default
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add native events under se:ieOptions.
Add disable native events function as the native event for ie is enabled by default
Xin the preceding checkbox, I verify that I have signed the Contributor License Agreement