Add the debuggerAddress option to chromium.js#9561
Merged
AutomatedTester merged 1 commit intoSeleniumHQ:trunkfrom Jul 15, 2021
Merged
Add the debuggerAddress option to chromium.js#9561AutomatedTester merged 1 commit intoSeleniumHQ:trunkfrom
AutomatedTester merged 1 commit intoSeleniumHQ:trunkfrom
Conversation
|
Kudos, SonarCloud Quality Gate passed! |
Member
|
Thanks for the PR. Could you give a bit more context about why this is needed? Currently, we get the debugger address from the capabilities returned and allow the driver to figure out where to put it. |
Contributor
Author
|
Thanks, I've updated the motivation in the PR description. |
AutomatedTester
approved these changes
Jul 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding a setter for Chromium's debuggerAddress capability. This is available in other language bindings but was missing from the JS bindings.
Motivation and Context
Chromium-based drivers provide the
debuggerAddressoption to let the user attach to an already-running browser instance at the specified address instead of launching a new one. One example where this is useful is certain WebView2 (WV2) scenarios. Users may want to test the web portion of an app that embeds WV2, but need to launch the app outside WebDriver first and drill through some native UI in order to activate the WV2 they are trying to test.Types of changes
Checklist