[py] fix type hints for selenium.webdriver.remote.file_detector #9647
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a module
selenium.types
that contains types reused throughout the codebase. Unfortunately, I forgot to include that in #9606, which caused tests breakage.Motivation and Context
The type of the input valid to be typed in a
WebElement
(Union[str, float, int]
) is required for typing in several modules, so the proposal to avoid duplication is to move it to a common moduleselenium.types
used to declare custom types. This approach is often used in large libraries, for example intensorflow
.Types of changes
Checklist