Publish tweaks + documentation #1107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
df721c4 to
7973294
Compare
7973294 to
ef84634
Compare
Gedochao
reviewed
Jun 21, 2022
84e873f to
d99e922
Compare
When setting up publishing from CI, version / computeVersion is the only missing parameter to publish locally. This allows to have "publish local" work after that setup.
--secret-key and --secret-key-password, so that users can specify things like ``` --secret-key config:pgp.secret-key --secret-key-password config:pgp.secret-key-password ```
d99e922 to
314aeb3
Compare
romanowski
reviewed
Jun 22, 2022
Member
romanowski
left a comment
There was a problem hiding this comment.
I have comments mostly related to docs.
223cdf4 to
20422b6
Compare
Those that are meant to be customized on CIs
Rather than a Scala 2.13 + a Scala 3 one
20422b6 to
cf3c728
Compare
romanowski
reviewed
Jun 24, 2022
|
|
||
| To override this default value, set the `publish.computeVersion` directive, like | ||
| ```scala | ||
| //> using publish.computeVersion "git:tag" |
Member
There was a problem hiding this comment.
I think we should link here to a doc explaining what computeVersions are supported and how each work
romanowski
reviewed
Jun 24, 2022
| provided as a convenience. | ||
|
|
||
| <!-- TODO Automatically generate that? --> | ||
| | | `using` directive | Command-line option | Example values | Notes | |
Member
There was a problem hiding this comment.
I wonder if we shouldn't explain what options means, since Licences is self-descriptive but VSC may not be
romanowski
approved these changes
Jun 24, 2022
Member
romanowski
left a comment
There was a problem hiding this comment.
I have left some comments but they can be applied in the follow-up.
|
|
||
| ### Other pre-defined repositories | ||
|
|
||
| All pre-defined repositories accepted by coursier, such as `jitpack` or `sonatype:snapshots`, are accepted as repositories for publishing. |
Member
There was a problem hiding this comment.
Does Coursier have a piece of doc about these repositories? If so, can we link it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tweaks things in the
publishsub-command (allowing to list licenses or checksum types, better defaults, acceptgithubas repository, …), and adds documentation for it.