Skip to content

Add --spark / --standalone-spark / --hadoop to the run command #1129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 22, 2022
Merged

Add --spark / --standalone-spark / --hadoop to the run command #1129

merged 4 commits into from
Aug 22, 2022

Conversation

alexarchambault
Copy link
Contributor

No description provided.

@alexarchambault

This comment was marked as outdated.

Sign in to view
@alexarchambault alexarchambault force-pushed the run-spark-hadoop branch 3 times, most recently from 007da47 to 9bf4999 Compare June 27, 2022 13:15
@alexarchambault alexarchambault mentioned this pull request Jul 8, 2022
Merged
@alexarchambault alexarchambault force-pushed the run-spark-hadoop branch 2 times, most recently from 6176311 to c5aeccc Compare July 11, 2022 14:58
@alexarchambault alexarchambault changed the title Add --command / --tmp-dir / --spark / --standalone-spark / --hadoop to the run command Add --spark / --standalone-spark / --hadoop to the run command Jul 11, 2022
@alexarchambault alexarchambault force-pushed the run-spark-hadoop branch 7 times, most recently from 52d63fa to f245f9a Compare July 15, 2022 15:42
@alexarchambault alexarchambault force-pushed the run-spark-hadoop branch 2 times, most recently from aa9d0d8 to f829809 Compare August 18, 2022 08:39
@alexarchambault alexarchambault marked this pull request as ready for review August 18, 2022 09:38
@ekrich
Copy link

ekrich commented Aug 19, 2022

This is a great idea to help Scala Spark adoption.

Gedochao
Gedochao reviewed Aug 22, 2022
View reviewed changes
Gedochao
Gedochao approved these changes Aug 22, 2022
View reviewed changes
Copy link
Contributor

@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some nitpicks, otherwise LGTM

@alexarchambault
Minor refacto of JavaHomeInfo
12500d3 
Useful in subsequent commits, adding a method on it
@alexarchambault alexarchambault merged commit de8ed99 into VirtusLab:main Aug 22, 2022
@alexarchambault alexarchambault deleted the run-spark-hadoop branch August 22, 2022 15:42
@Gedochao Gedochao added the enhancement New feature or request label Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gedochao Gedochao Gedochao approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexarchambault @ekrich @Gedochao