Skip to content

Actionable diagnostics #1229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 19, 2022
Merged

Actionable diagnostics #1229

merged 7 commits into from
Aug 19, 2022

Conversation

lwronski
Copy link
Contributor

@lwronski lwronski commented Aug 3, 2022 •
edited
Loading

The next part of changes that are necessary before the integration with Metals.

@lwronski lwronski force-pushed the actionable-diagnostics branch 2 times, most recently from 4938397 to 3d868d1 Compare August 3, 2022 13:44
@lwronski lwronski force-pushed the actionable-diagnostics branch 2 times, most recently from 2678b0b to de44e09 Compare August 3, 2022 15:37
@lwronski lwronski force-pushed the actionable-diagnostics branch from de44e09 to 71954ef Compare August 3, 2022 16:05
@lwronski lwronski requested a review from Gedochao August 3, 2022 16:43
@lwronski lwronski marked this pull request as ready for review August 3, 2022 16:43
@lwronski lwronski requested a review from wleczny August 3, 2022 16:43
alexarchambault
alexarchambault approved these changes Aug 19, 2022
View reviewed changes
Copy link
Contributor

@alexarchambault alexarchambault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for either squash-and-merge, or adjust format / reference doc in the first 6 commits, so that the "Fix scalafmt" one isn't necessary.

@lwronski lwronski merged commit 1719919 into VirtusLab:main Aug 19, 2022
@Gedochao Gedochao added enhancement New feature or request IDE labels Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexarchambault alexarchambault alexarchambault approved these changes

@Gedochao Gedochao Gedochao approved these changes

@wleczny wleczny Awaiting requested review from wleczny

Assignees
No one assigned
Labels
enhancement New feature or request IDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lwronski @alexarchambault @Gedochao