Skip to content

Add CLI option for suppressing the warning about directives in multiple files #1754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2023
Merged

Add CLI option for suppressing the warning about directives in multiple files #1754

merged 1 commit into from
Jan 16, 2023

Conversation

MaciejG604
Copy link
Contributor

@MaciejG604 MaciejG604 commented Jan 9, 2023 •
edited
Loading

No description provided.

@MaciejG604 MaciejG604 changed the title Add flag for suppressing the warning about directives in multiple files Add CLI option for suppressing the warning about directives in multiple files Jan 9, 2023
@MaciejG604 MaciejG604 force-pushed the silence-directives-in-multiple-files-warning branch from 99bc143 to 6997503 Compare January 9, 2023 11:51
@MaciejG604 MaciejG604 marked this pull request as ready for review January 9, 2023 12:00
@MaciejG604 MaciejG604 force-pushed the silence-directives-in-multiple-files-warning branch from 6d06359 to f3bbc75 Compare January 9, 2023 22:38
Gedochao
Gedochao reviewed Jan 10, 2023
View reviewed changes
@MaciejG604 MaciejG604 force-pushed the silence-directives-in-multiple-files-warning branch 2 times, most recently from c624600 to a8e74fa Compare January 12, 2023 11:11
Gedochao
Gedochao reviewed Jan 12, 2023
View reviewed changes
@MaciejG604 MaciejG604 force-pushed the silence-directives-in-multiple-files-warning branch 2 times, most recently from d68ae93 to 6cf961d Compare January 12, 2023 13:17
@MaciejG604 MaciejG604 requested a review from Gedochao January 12, 2023 14:54
Gedochao
Gedochao approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaciejG604 MaciejG604 force-pushed the silence-directives-in-multiple-files-warning branch from a9db1df to 42c7435 Compare January 13, 2023 13:37
@MaciejG604 MaciejG604 merged commit 0dabcfc into VirtusLab:main Jan 16, 2023
@Gedochao Gedochao mentioned this pull request Jan 16, 2023
Merged
@Gedochao Gedochao added the bug Something isn't working label Jan 18, 2023
@carlosedp
Copy link
Contributor

carlosedp commented Feb 2, 2023 •
edited
Loading

This apparently fixes #1828

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gedochao Gedochao Gedochao approved these changes

@lwronski lwronski lwronski approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MaciejG604 @carlosedp @Gedochao @lwronski