Skip to content

Prevent downloading Java 17 when running a REPL without sources #2305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 25, 2023
Merged

Prevent downloading Java 17 when running a REPL without sources #2305

merged 2 commits into from
Jul 25, 2023

Conversation

lwronski
Copy link
Contributor

Fixes #2268

@lwronski lwronski requested a review from MaciejG604 July 21, 2023 08:51
@lwronski lwronski force-pushed the repl-java-8 branch 2 times, most recently from 3291a69 to 06e28bb Compare July 25, 2023 06:58
@MaciejG604 MaciejG604 changed the title Prevent download a Java 17 when running a REPL without sources Prevent downloading Java 17 when running a REPL without sources Jul 25, 2023
MaciejG604
MaciejG604 approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@MaciejG604 MaciejG604 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lwronski lwronski merged commit 601b458 into VirtusLab:main Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

@MaciejG604 MaciejG604 MaciejG604 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

scala-cli downloads JVM temurin 17 with no need (I already have preinstalled JDK 20 and JDK 17)
3 participants
@lwronski @tgodzik @MaciejG604