Skip to content

Tag native packager tests as flaky #3344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Gedochao
Copy link
Contributor

@Gedochao Gedochao commented Dec 3, 2024

It seems this is intermittently failing on main again.
https://github.com/VirtusLab/scala-cli/actions/runs/12138100458/job/33843240683#step:5:11645

I assumed it got fixed in #3311, but it seems there's something else causing it to be flaky.

I reopened the issue:

@Gedochao Gedochao enabled auto-merge (squash) December 3, 2024 14:03
@@ -430,7 +430,8 @@ class NativePackagerTests extends ScalaCliSuite {
}

if (Properties.isLinux)
test("building docker image with scala native app") {
// FIXME this got flaky on the CI again
test("building docker image with scala native app".flaky) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have an open issue for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I mentioned it in the PR description.
I reopened this:

@tgodzik tgodzik disabled auto-merge December 3, 2024 14:58
@tgodzik tgodzik merged commit 88a31cb into VirtusLab:main Dec 3, 2024
40 checks passed
@Gedochao Gedochao deleted the maintenance/flaky-native-packager-tests branch December 3, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants