Skip to content

Allow text-2.0, accurate dep bounds #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 8, 2022
Merged

Allow text-2.0, accurate dep bounds #33

merged 2 commits into from
Mar 8, 2022

Conversation

ysangkok
Copy link
Contributor

@ysangkok ysangkok commented Mar 7, 2022

Tested using this configuration as an example of Aeson between 2 and 2.0.2 (also demonstrates text>=2):

cabal test --constraint 'text>=2' --constraint='generic-arbitrary<0.3' -w ghc-9.0.2 --enable-tests --constraint='aeson==2.0.2.0'

Using this for Aeson 2.0.3+:

cabal test --constraint='generic-arbitrary<0.3' -w ghc-9.0.2 --enable-tests --constraint='aeson==2.0.3.0'

The cabal file is regenerated and this lowers the generic-arbitrary bound which was raised to allow the 0.3 series, even though it isn't even released.

Copy link
Owner

@Vlix Vlix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, just a small adjustment needed in /test.

And yeah, the cabal file having generic-arbitrary < 0.4 was an oversight on my part. Somewhere in making a PR I forgot to build before pushing, I think.

@Vlix Vlix merged commit 02bf794 into Vlix:master Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants