Make '-webkit-background-size' a legacy shorthand #3372

pxlcoder · 2022-08-16T20:26:20Z

`856140e`

Make '-webkit-background-size' a legacy shorthand
https://bugs.webkit.org/show_bug.cgi?id=243562
rdar://98151497

Reviewed by Tim Nguyen.

`background-size` and `-webkit-background-size` are a pair of properties that
share a computed style. `-webkit-background-size` differs from `background-size`
in the interpretation of a single value: `-webkit-background-size: l;` is
equivalent to `background-size: l l;`, whereas `background-size: l;` is
equivalent to `background-size: l auto;`.

Property pairs that share a computed style but differ in syntax should be
implemented as legacy shorthands.

Additionally, always serialize `background-size` and `-webkit-background-size`
as two values, so that values can be roundtripped between the prefixed and
unprefixed variant.

Spec: https://www.w3.org/TR/css-cascade-5/#aliasing

* LayoutTests/TestExpectations:

Remove expectations for a forms test that was unexpectedly setting
`-webkit-background-size`, as it was not a shorthand.

* LayoutTests/fast/backgrounds/background-shorthand-with-backgroundSize-style-expected.txt:
* LayoutTests/fast/backgrounds/background-shorthand-with-backgroundSize-style.html:
* LayoutTests/fast/backgrounds/size/parsing-background-size-values-expected.txt:
* LayoutTests/fast/backgrounds/size/parsing-inherit-expected.txt:
* LayoutTests/fast/backgrounds/size/resources/parsing-background-size-values.js:
* LayoutTests/fast/backgrounds/size/resources/parsing-inherit.js:
* LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt:
* LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-animations/KeyframeEffect-getKeyframes.tentative.html:

Update test to use two-value syntax.

* LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/background-332-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/background-size-001.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/background-size-computed.html:
* LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-pseudo-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/quirks/unitless-length/excluded-properties-002-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/quirks/unitless-length/excluded-properties-002.html:

Include an additional check for `1234px auto`, to avoid a false positive, as `background-size` is serialized to two values.

* LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
* LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-pseudo-expected.txt:
* LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-pseudo-expected.txt:
* LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
* LayoutTests/platform/ipad/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
* LayoutTests/platform/ipad/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-pseudo-expected.txt:
* LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
* LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-pseudo-expected.txt:
* LayoutTests/svg/css/getComputedStyle-basic-expected.txt:
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::fillSizeToCSSValue):

Return two values from `getComputedStyle` unless the value is "cover", "contain", or "auto".

(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
* Source/WebCore/css/StyleProperties.cpp:
(WebCore::StyleProperties::getPropertyValue const):
* Source/WebCore/css/parser/CSSPropertyParser.cpp:
(WebCore::consumeBackgroundSize):

Always serialize `background-size` and `-webkit-background-size` as two values.

(WebCore::CSSPropertyParser::parseSingleValue):
(WebCore::CSSPropertyParser::parseShorthand):

Canonical link: https://commits.webkit.org/254925@main

5325011

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk1
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
✅ 🛠 🧪 merge	✅ 🛠 watch	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

Loirooriol · 2022-08-17T00:00:43Z

Source/WebCore/css/StyleProperties.cpp

@@ -376,6 +376,8 @@ String StyleProperties::getPropertyValue(CSSPropertyID propertyID, Document* doc
        return get2Values(scrollPaddingInlineShorthand());
    case CSSPropertyWebkitTextOrientation:
        return getPropertyValue(CSSPropertyTextOrientation);
+    case CSSPropertyWebkitBackgroundSize:
+        return getPropertyValue(CSSPropertyBackgroundSize);


That's not good, there is no round-trip:

element.style.backgroundSize = "100px"; // behaves as "100px auto" element.style.webkitBackgroundSize; // "100px", oops! element.style.webkitBackgroundSize += ""; // changes behavior to "100px 100px"

element.style.webkitBackgroundSize = "100px"; // behaves as "100px 100px" element.style.backgroundSize; // "100px", oops! element.style.backgroundSize += ""; // changes behavior to "100px auto"

And I guess this was already wrong, but please fix gCS while you are at it:

element.style.backgroundSize = "100px"; getComputedStyle(element).webkitBackgroundSize; // "100px", oops!

This is OK:

element.style.webkitBackgroundSize = "100px"; getComputedStyle(element).backgroundSize; // "100px 100px"

See whatwg/compat#28, either serialize background-size and -webkit-background-size differently, or always use 2 values. People there seemed to prefer 2 values.

Yes, and make the unprefixed property parse like -webkit-background-size if it's web-compatible. whatwg/compat#28 (comment)

Changing the parsing is out-of-scope for this change, and would carry more web compat risk.

I have changed serialization to always use two values.

Source/WebCore/css/CSSProperties.json

Source/WebCore/css/parser/CSSPropertyParser.cpp

webkit-early-warning-system · 2022-09-23T05:14:05Z

EWS run on previous version of this PR (hash 1ddd2b7)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	❌ 🧪 mac-wk1
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2
	✅ 🛠 watch	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-09-23T05:14:06Z

EWS run on previous version of this PR (hash a6fa5c8)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	❌ 🧪 mac-wk1
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2
	✅ 🛠 watch	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

Source/WebCore/css/parser/CSSPropertyParser.cpp

webkit-early-warning-system · 2022-09-23T22:30:46Z

Starting EWS tests for 50a2514. Live statuses available at the PR page, #3372

webkit-early-warning-system · 2022-09-23T22:30:47Z

EWS run on previous version of this PR (hash 50a2514)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	❌ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk1
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
	✅ 🛠 watch	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

Loirooriol

Informal LGTM.
It would be good to fix getComputedStyle while you are at it, but it's already broken so not blocking on that.

nt1m · 2022-09-23T23:08:05Z

It would be good to fix getComputedStyle while you are at it, but it's already broken so not blocking on that.

I think Aditya's patch makes sure to always serialize to 2 values, so that would also get fixed, I would think.

We could add a test for it.

Loirooriol · 2022-09-23T23:12:04Z

No, getComputedStyle still omits the 2nd value if it's auto, which is wrong for -webkit-background-size. See https://searchfox.org/wubkat/rev/7b1a4e7e5fb469b0eea41fe131f2f190d08f2383/Source/WebCore/css/ComputedStyleExtractor.cpp#2115-2116

    if (fillSize.size.height.isAuto())
        return ComputedStyleExtractor::zoomAdjustedPixelValueForLength(fillSize.size.width, style);

nt1m · 2022-09-24T06:32:58Z

No, getComputedStyle still omits the 2nd value if it's auto, which is wrong for -webkit-background-size. See https://searchfox.org/wubkat/rev/7b1a4e7e5fb469b0eea41fe131f2f190d08f2383/Source/WebCore/css/ComputedStyleExtractor.cpp#2115-2116
    if (fillSize.size.height.isAuto())
        return ComputedStyleExtractor::zoomAdjustedPixelValueForLength(fillSize.size.width, style);

Good catch! Seems easily fixable, we could pass in a CSSPropertyID for fillSizeToCSSValue and only do this adjustment for the gCS for mask-size

webkit-early-warning-system · 2022-09-24T20:59:01Z

EWS run on previous version of this PR (hash a56e956)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	❌ 🛠 wpe	❌ 🛠 🧪 win
❌ 🧪 bindings	❌ 🛠 ios-sim	⏳ 🛠 mac-debug	❌ 🛠 gtk	❌ 🛠 wincairo
❌ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	❌ 🧪 api-ios	❌ 🧪 api-mac	❌ 🧪 api-gtk
	❌ 🛠 tv	❌ 🧪 mac-wk1
	❌ 🛠 tv-sim	❌ 🧪 mac-wk2
	❌ 🛠 watch	❌ 🧪 mac-AS-debug-wk2
	❌ 🛠 watch-sim	❌ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-09-24T21:19:57Z

EWS run on previous version of this PR (hash e226b87)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	⏳ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	❌ 🧪 mac-wk1
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2
	✅ 🛠 watch	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

nt1m

r=me with tests on EWS changed to match the new expected results (change the expected results to keep them passing)

Also, please do a WPT export.

pxlcoder · 2022-09-25T00:32:10Z

Following the change to gCS, the following WPTs are failing:

imported/w3c/web-platform-tests/css/css-backgrounds/background-332.html
imported/w3c/web-platform-tests/css/css-backgrounds/background-size-001.html
imported/w3c/web-platform-tests/css/css-backgrounds/parsing/background-size-computed.html
imported/w3c/web-platform-tests/css/cssom/getComputedStyle-pseudo.html

They expect a single value for background-size, when a single value is specified. If I were to update the tests to match our new behavior, they would fail on other browsers. Using assert_any would fix that issue, but also seems a little strange.

@nt1m @zcorpan Any suggestions on how to proceed with gCS / these WPT?

nt1m · 2022-09-25T00:47:28Z

@pxlcoder You can either change the expected result, or use assert_in_array() to accept both forms. I slightly favor the first option to make other browsers follow suit (or participate in the discussion for whatwg/compat#28), and getting interoperable behavior.

webkit-early-warning-system · 2022-09-25T01:51:07Z

EWS run on current version of this PR (hash 99a4aaf)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
🧪 style	⏳ 🛠 ios	⏳ 🛠 mac	🛠 wpe	🛠 🧪 win
🧪 bindings	🛠 ios-sim	⏳ 🛠 mac-debug	🛠 gtk	🛠 wincairo
⏳ 🧪 webkitperl	🧪 ios-wk2	⏳ 🛠 mac-AS-debug	🧪 gtk-wk2
	🧪 api-ios	⏳ 🧪 api-mac	🧪 api-gtk
⏳ 🛠 🧪 jsc	🛠 tv	⏳ 🧪 mac-wk1
🧪 services	⏳ 🛠 tv-sim	⏳ 🧪 mac-wk2
	🛠 watch	⏳ 🧪 mac-AS-debug-wk2
	🛠 watch-sim	⏳ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-09-25T01:51:09Z

EWS run on previous version of this PR (hash 99a4aaf)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk1
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
	✅ 🛠 watch	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

nt1m

Can you add a GTK specific baseline for:
LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-pseudo.html ?

This is actually not a regression of your patch but of a3ee3aa , but would be nice to fix anyway here since your patch touches the baseline.

nt1m · 2022-09-25T06:56:05Z

Source/WebCore/css/ComputedStyleExtractor.cpp

@@ -2110,15 +2110,15 @@ static Ref<CSSValue> maskModeToCSSValue(MaskMode type)
    return CSSValuePool::singleton().createValue(CSSValueMatchSource);
 }

-static Ref<CSSValue> fillSizeToCSSValue(const FillSize& fillSize, const RenderStyle& style)
+static Ref<CSSValue> fillSizeToCSSValue(const FillSize& fillSize, const RenderStyle& style, CSSPropertyID propertyID)


Can you make the propertyID the first argument to be consistent with createPositionListForLayer and createSingleAxisPositionValueForLayer?

webkit-early-warning-system · 2022-09-26T05:54:10Z

EWS run on previous version of this PR (hash 4682b66)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 🧪 win
	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk1
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
	✅ 🛠 watch	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

nt1m · 2022-09-26T14:37:42Z

iOS needs a similar rebaseline for LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-pseudo.html

pxlcoder · 2022-09-26T16:43:43Z

iOS needs a similar rebaseline for LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-pseudo.html

Not sure what's going on here – the patch contains a baseline in LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-pseudo-expected.txt, and the test is passing locally 🤔

pxlcoder · 2022-09-26T17:20:45Z

(turns out there's already a baseline in ios-wk2, will update that one instead of adding a new one)

webkit-early-warning-system · 2022-09-26T17:24:54Z

EWS run on current version of this PR (hash 5325011)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk1
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
✅ 🛠 🧪 merge	✅ 🛠 watch	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

https://bugs.webkit.org/show_bug.cgi?id=243562 rdar://98151497 Reviewed by Tim Nguyen. `background-size` and `-webkit-background-size` are a pair of properties that share a computed style. `-webkit-background-size` differs from `background-size` in the interpretation of a single value: `-webkit-background-size: l;` is equivalent to `background-size: l l;`, whereas `background-size: l;` is equivalent to `background-size: l auto;`. Property pairs that share a computed style but differ in syntax should be implemented as legacy shorthands. Additionally, always serialize `background-size` and `-webkit-background-size` as two values, so that values can be roundtripped between the prefixed and unprefixed variant. Spec: https://www.w3.org/TR/css-cascade-5/#aliasing * LayoutTests/TestExpectations: Remove expectations for a forms test that was unexpectedly setting `-webkit-background-size`, as it was not a shorthand. * LayoutTests/fast/backgrounds/background-shorthand-with-backgroundSize-style-expected.txt: * LayoutTests/fast/backgrounds/background-shorthand-with-backgroundSize-style.html: * LayoutTests/fast/backgrounds/size/parsing-background-size-values-expected.txt: * LayoutTests/fast/backgrounds/size/parsing-inherit-expected.txt: * LayoutTests/fast/backgrounds/size/resources/parsing-background-size-values.js: * LayoutTests/fast/backgrounds/size/resources/parsing-inherit.js: * LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt: * LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-animations/KeyframeEffect-getKeyframes.tentative.html: Update test to use two-value syntax. * LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/background-332-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/background-size-001.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/background-size-computed.html: * LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-pseudo-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/quirks/unitless-length/excluded-properties-002-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/quirks/unitless-length/excluded-properties-002.html: Include an additional check for `1234px auto`, to avoid a false positive, as `background-size` is serialized to two values. * LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt: * LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-pseudo-expected.txt: * LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-pseudo-expected.txt: * LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt: * LayoutTests/platform/ipad/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt: * LayoutTests/platform/ipad/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-pseudo-expected.txt: * LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: * LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt: * LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-pseudo-expected.txt: * LayoutTests/svg/css/getComputedStyle-basic-expected.txt: * Source/WebCore/css/CSSProperties.json: * Source/WebCore/css/ComputedStyleExtractor.cpp: (WebCore::fillSizeToCSSValue): Return two values from `getComputedStyle` unless the value is "cover", "contain", or "auto". (WebCore::ComputedStyleExtractor::valueForPropertyInStyle): * Source/WebCore/css/StyleProperties.cpp: (WebCore::StyleProperties::getPropertyValue const): * Source/WebCore/css/parser/CSSPropertyParser.cpp: (WebCore::consumeBackgroundSize): Always serialize `background-size` and `-webkit-background-size` as two values. (WebCore::CSSPropertyParser::parseSingleValue): (WebCore::CSSPropertyParser::parseShorthand): Canonical link: https://commits.webkit.org/254925@main

webkit-commit-queue · 2022-09-27T18:16:28Z

Committed 254925@main (856140e): https://commits.webkit.org/254925@main

Reviewed commits have been landed. Closing PR #3372 and removing active labels.

pxlcoder self-assigned this Aug 16, 2022

pxlcoder added Forms For bugs specific to form elements (checkboxes, buttons, text fields, etc.) WebKit Nightly Build labels Aug 16, 2022

pxlcoder marked this pull request as draft August 16, 2022 20:27

nt1m requested a review from Loirooriol August 16, 2022 21:22

Loirooriol requested changes Aug 17, 2022

View reviewed changes

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Aug 17, 2022

nt1m reviewed Aug 17, 2022

View reviewed changes

Source/WebCore/css/parser/CSSPropertyParser.cpp Outdated Show resolved Hide resolved

karlcow mentioned this pull request Aug 18, 2022

-webkit-background-size has behavioural differences to background-size whatwg/compat#28

Open

pxlcoder removed the merging-blocked Applied to prevent a change from being merged label Sep 23, 2022

pxlcoder force-pushed the eng/243562 branch from a6fa5c8 to 1ddd2b7 Compare September 23, 2022 05:13

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 23, 2022

Loirooriol reviewed Sep 23, 2022

View reviewed changes

Source/WebCore/css/parser/CSSPropertyParser.cpp Outdated Show resolved Hide resolved

pxlcoder removed the merging-blocked Applied to prevent a change from being merged label Sep 23, 2022

pxlcoder force-pushed the eng/243562 branch from 1ddd2b7 to 50a2514 Compare September 23, 2022 22:28

Loirooriol approved these changes Sep 23, 2022

View reviewed changes

pxlcoder force-pushed the eng/243562 branch from 50a2514 to a56e956 Compare September 24, 2022 20:58

pxlcoder force-pushed the eng/243562 branch from a56e956 to e226b87 Compare September 24, 2022 21:19

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 24, 2022

nt1m approved these changes Sep 25, 2022

View reviewed changes

pxlcoder removed the merging-blocked Applied to prevent a change from being merged label Sep 25, 2022

pxlcoder force-pushed the eng/243562 branch from e226b87 to 99a4aaf Compare September 25, 2022 01:50

pxlcoder marked this pull request as ready for review September 25, 2022 01:51

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 25, 2022

nt1m approved these changes Sep 25, 2022

View reviewed changes

pxlcoder removed the merging-blocked Applied to prevent a change from being merged label Sep 26, 2022

pxlcoder force-pushed the eng/243562 branch from 99a4aaf to 4682b66 Compare September 26, 2022 05:53

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 26, 2022

pxlcoder removed the merging-blocked Applied to prevent a change from being merged label Sep 26, 2022

pxlcoder force-pushed the eng/243562 branch from 4682b66 to 5325011 Compare September 26, 2022 17:24

pxlcoder added the merge-queue Applied to send a pull request to merge-queue label Sep 27, 2022

webkit-early-warning-system force-pushed the eng/243562 branch from 5325011 to 856140e Compare September 27, 2022 18:16

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Sep 27, 2022

webkit-early-warning-system merged commit 856140e into WebKit:main Sep 27, 2022

zcorpan mentioned this pull request Sep 28, 2022

[css-backgrounds] Always serialize 'background-size' and mask-size as two values w3c/csswg-drafts#7802

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make '-webkit-background-size' a legacy shorthand #3372

Make '-webkit-background-size' a legacy shorthand #3372

pxlcoder commented Aug 16, 2022 •

edited by webkit-early-warning-system

Loading

Loirooriol Aug 17, 2022

zcorpan Sep 1, 2022

pxlcoder Sep 23, 2022

webkit-early-warning-system commented Sep 23, 2022 •

edited

Loading

webkit-early-warning-system commented Sep 23, 2022

webkit-early-warning-system commented Sep 23, 2022

webkit-early-warning-system commented Sep 23, 2022 •

edited

Loading

Loirooriol left a comment

nt1m commented Sep 23, 2022

Loirooriol commented Sep 23, 2022

nt1m commented Sep 24, 2022

webkit-early-warning-system commented Sep 24, 2022 •

edited

Loading

webkit-early-warning-system commented Sep 24, 2022 •

edited

Loading

nt1m left a comment •

edited

Loading

pxlcoder commented Sep 25, 2022

nt1m commented Sep 25, 2022

webkit-early-warning-system commented Sep 25, 2022 •

edited

Loading

webkit-early-warning-system commented Sep 25, 2022 •

edited

Loading

nt1m left a comment

nt1m Sep 25, 2022

webkit-early-warning-system commented Sep 26, 2022 •

edited

Loading

nt1m commented Sep 26, 2022

pxlcoder commented Sep 26, 2022

pxlcoder commented Sep 26, 2022

webkit-early-warning-system commented Sep 26, 2022 •

edited

Loading

webkit-commit-queue commented Sep 27, 2022

Make '-webkit-background-size' a legacy shorthand #3372

Make '-webkit-background-size' a legacy shorthand #3372

Conversation

pxlcoder commented Aug 16, 2022 • edited by webkit-early-warning-system Loading

856140e

Loirooriol Aug 17, 2022

Choose a reason for hiding this comment

zcorpan Sep 1, 2022

Choose a reason for hiding this comment

pxlcoder Sep 23, 2022

Choose a reason for hiding this comment

webkit-early-warning-system commented Sep 23, 2022 • edited Loading

webkit-early-warning-system commented Sep 23, 2022

webkit-early-warning-system commented Sep 23, 2022

webkit-early-warning-system commented Sep 23, 2022 • edited Loading

Loirooriol left a comment

Choose a reason for hiding this comment

nt1m commented Sep 23, 2022

Loirooriol commented Sep 23, 2022

nt1m commented Sep 24, 2022

webkit-early-warning-system commented Sep 24, 2022 • edited Loading

webkit-early-warning-system commented Sep 24, 2022 • edited Loading

nt1m left a comment • edited Loading

Choose a reason for hiding this comment

pxlcoder commented Sep 25, 2022

nt1m commented Sep 25, 2022

webkit-early-warning-system commented Sep 25, 2022 • edited Loading

webkit-early-warning-system commented Sep 25, 2022 • edited Loading

nt1m left a comment

Choose a reason for hiding this comment

nt1m Sep 25, 2022

Choose a reason for hiding this comment

webkit-early-warning-system commented Sep 26, 2022 • edited Loading

nt1m commented Sep 26, 2022

pxlcoder commented Sep 26, 2022

pxlcoder commented Sep 26, 2022

webkit-early-warning-system commented Sep 26, 2022 • edited Loading

webkit-commit-queue commented Sep 27, 2022

pxlcoder commented Aug 16, 2022 •

edited by webkit-early-warning-system

Loading

`856140e`

webkit-early-warning-system commented Sep 23, 2022 •

edited

Loading

webkit-early-warning-system commented Sep 23, 2022 •

edited

Loading

webkit-early-warning-system commented Sep 24, 2022 •

edited

Loading

webkit-early-warning-system commented Sep 24, 2022 •

edited

Loading

nt1m left a comment •

edited

Loading

webkit-early-warning-system commented Sep 25, 2022 •

edited

Loading

webkit-early-warning-system commented Sep 25, 2022 •

edited

Loading

webkit-early-warning-system commented Sep 26, 2022 •

edited

Loading

webkit-early-warning-system commented Sep 26, 2022 •

edited

Loading