Skip to content

Conversation

@Artyom17
Copy link
Contributor

@Artyom17 Artyom17 commented Jun 7, 2019

Description:
Fixing issue #4198: VR deep-linking / VR navigation doesn't work.

Changes proposed:

  • Canvas must have gl context associated with it for requestPresent to work;
  • onVRDisplayPresentChange by spec is called only once for the first requestPresent (which might be called from the ondisplayactivate and can't init all the data); so, firing the second event "artificially".

@Artyom17 Artyom17 marked this pull request as ready for review June 7, 2019 00:36
@dmarcos
Copy link
Member

dmarcos commented Jun 7, 2019

It looks good to me. Just a small change and it's ready to go. Thank you very much for this and investigating the issue. Glad to have robust in-vr navigation again 👏

@dmarcos
Copy link
Member

dmarcos commented Jun 7, 2019

Awesome. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants