Add call to container/{id}/wait #329

ry99 · 2020-04-02T19:11:49Z

Adds a container.waitOn() function to wait for a container to complete. I did not add an integration test because the integration tests do not seem to work on my dev machine (#303).

amihaiemil · 2020-04-02T19:35:58Z

@ry99 Thank you for your PR. Could you at least add a simple unit tests? See how other unit tests are implemented, it should be very similar :)

amihaiemil

@ry99 also, see 2 comments :)

src/main/java/com/amihaiemil/docker/Container.java

src/main/java/com/amihaiemil/docker/RtContainer.java

0crat · 2020-04-02T19:49:23Z

@amihaiemil /z not enough funds available in the project, can't set budget of job #329, see §21; @amihaiemil /z will get no money on completion; in order to fix that, add funds to the project and assign the job again

amihaiemil · 2020-04-03T06:29:17Z

@rultor try to merge

rultor · 2020-04-03T06:31:27Z

@rultor try to merge

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2020-04-03T06:34:01Z

@rultor try to merge

@amihaiemil Done! FYI, the full log is here (took me 2min)

amihaiemil · 2020-04-03T06:36:19Z

@ry99 thanks a lot for the PR!

amihaiemil · 2020-04-03T06:36:49Z

@rultor release it, tag is 0.0.12

rultor · 2020-04-03T06:37:37Z

@rultor release it, tag is 0.0.12

@amihaiemil OK, I will release it now. Please check the progress here

rultor · 2020-04-03T06:40:18Z

@rultor release it, tag is 0.0.12

@amihaiemil @ry99 Oops, I failed. You can see the full log here (spent 2min)

Generating /home/r/repo/target/apidocs/com/amihaiemil/docker/class-use/Container.html...
Generating /home/r/repo/target/apidocs/com/amihaiemil/docker/class-use/TcpDocker.html...
Generating /home/r/repo/target/apidocs/com/amihaiemil/docker/class-use/Docker.html...
Generating /home/r/repo/target/apidocs/com/amihaiemil/docker/class-use/Containers.html...
Generating /home/r/repo/target/apidocs/com/amihaiemil/docker/class-use/UnexpectedResponseException.html...
Generating /home/r/repo/target/apidocs/com/amihaiemil/docker/class-use/Credentials.html...
Generating /home/r/repo/target/apidocs/com/amihaiemil/docker/class-use/Logs.html...
Generating /home/r/repo/target/apidocs/com/amihaiemil/docker/class-use/Network.html...
Generating /home/r/repo/target/apidocs/com/amihaiemil/docker/class-use/UnixDocker.html...
Generating /home/r/repo/target/apidocs/com/amihaiemil/docker/class-use/Image.html...
Generating /home/r/repo/target/apidocs/com/amihaiemil/docker/class-use/IdentityToken.html...
Generating /home/r/repo/target/apidocs/com/amihaiemil/docker/class-use/Networks.html...
Generating /home/r/repo/target/apidocs/com/amihaiemil/docker/class-use/RegistryConfigAuth.html...
Generating /home/r/repo/target/apidocs/com/amihaiemil/docker/class-use/Version.html...
Generating /home/r/repo/target/apidocs/com/amihaiemil/docker/class-use/Volume.html...
Generating /home/r/repo/target/apidocs/com/amihaiemil/docker/package-use.html...
Building index for all the packages and classes...
Generating /home/r/repo/target/apidocs/overview-tree.html...
Generating /home/r/repo/target/apidocs/index-all.html...
Generating /home/r/repo/target/apidocs/deprecated-list.html...
Building index for all classes...
Generating /home/r/repo/target/apidocs/allclasses-frame.html...
Generating /home/r/repo/target/apidocs/allclasses-noframe.html...
Generating /home/r/repo/target/apidocs/index.html...
Generating /home/r/repo/target/apidocs/help-doc.html...
Note: Custom tags that could override future standard tags:  @todo, @checkstyle. To avoid potential overrides, use at least one period character (.) in custom tag names.
Note: Custom tags that were not seen:  @todo, @checkstyle
2 errors
3 warnings
[\u001b[1;34mINFO\u001b[m] \u001b[1m------------------------------------------------------------------------\u001b[m
[\u001b[1;34mINFO\u001b[m] \u001b[1;31mBUILD FAILURE\u001b[m
[\u001b[1;34mINFO\u001b[m] \u001b[1m------------------------------------------------------------------------\u001b[m
[\u001b[1;34mINFO\u001b[m] Total time:  32.485 s
[\u001b[1;34mINFO\u001b[m] Finished at: 2020-04-03T06:38:49Z
[\u001b[1;34mINFO\u001b[m] \u001b[1m------------------------------------------------------------------------\u001b[m
[\u001b[1;31mERROR\u001b[m] Failed to execute goal \u001b[32morg.apache.maven.plugins:maven-javadoc-plugin:2.10.3:jar\u001b[m \u001b[1m(attach-javadocs)\u001b[m on project \u001b[36mdocker-java-api\u001b[m: \u001b[1;31mMavenReportException: Error while generating Javadoc: \u001b[m
[\u001b[1;31mERROR\u001b[m] \u001b[1;31mExit code: 1 - /home/r/repo/src/main/java/com/amihaiemil/docker/Container.java:166: warning - Tag @see: missing final '>': "<a href="https://docs.docker.com/engine/api/v1.35/#operation/ContainerWait">\u001b[m
[\u001b[1;31mERROR\u001b[m] \u001b[1;31m Wait Container</a>."\u001b[m
[\u001b[1;31mERROR\u001b[m] \u001b[1;31m/home/r/repo/src/main/java/com/amihaiemil/docker/LocalDocker.java:46: error: reference not found\u001b[m
[\u001b[1;31mERROR\u001b[m] \u001b[1;31m * via {@link #LocalUnixDocker(HttpClient, String)}.\u001b[m
[\u001b[1;31mERROR\u001b[m] \u001b[1;31m              ^\u001b[m
[\u001b[1;31mERROR\u001b[m] \u001b[1;31m/home/r/repo/src/main/java/com/amihaiemil/docker/LocalDocker.java:54: warning - Tag @link: can't find LocalUnixDocker(HttpClient, String) in com.amihaiemil.docker.LocalDocker\u001b[m
[\u001b[1;31mERROR\u001b[m] \u001b[1;31m/home/r/repo/src/main/java/com/amihaiemil/docker/UnixDocker.java:42: error: reference not found\u001b[m
[\u001b[1;31mERROR\u001b[m] \u001b[1;31m * via {@link #LocalUnixDocker(HttpClient, String)}.\u001b[m
[\u001b[1;31mERROR\u001b[m] \u001b[1;31m              ^\u001b[m
[\u001b[1;31mERROR\u001b[m] \u001b[1;31m/home/r/repo/src/main/java/com/amihaiemil/docker/UnixDocker.java:48: warning - Tag @link: can't find LocalUnixDocker(HttpClient, String) in com.amihaiemil.docker.UnixDocker\u001b[m
[\u001b[1;31mERROR\u001b[m] \u001b[1;31m\u001b[m
[\u001b[1;31mERROR\u001b[m] \u001b[1;31mCommand line was: /usr/lib/jvm/java-1.8-openjdk/jre/../bin/javadoc @options @packages\u001b[m
[\u001b[1;31mERROR\u001b[m] \u001b[1;31m\u001b[m
[\u001b[1;31mERROR\u001b[m] \u001b[1;31mRefer to the generated Javadoc files in '/home/r/repo/target/apidocs' dir.\u001b[m
[\u001b[1;31mERROR\u001b[m] \u001b[1;31m\u001b[m
[\u001b[1;31mERROR\u001b[m] -> \u001b[1m[Help 1]\u001b[m
[\u001b[1;31mERROR\u001b[m] 
[\u001b[1;31mERROR\u001b[m] To see the full stack trace of the errors, re-run Maven with the \u001b[1m-e\u001b[m switch.
[\u001b[1;31mERROR\u001b[m] Re-run Maven using the \u001b[1m-X\u001b[m switch to enable full debug logging.
[\u001b[1;31mERROR\u001b[m] 
[\u001b[1;31mERROR\u001b[m] For more information about the errors and possible solutions, please read the following articles:
[\u001b[1;31mERROR\u001b[m] \u001b[1m[Help 1]\u001b[m http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
container 0d30b9a4ed5eed20b6334150c861da1f34a2377aaaea50f21696fda1c88fadac is dead
Fri Apr  3 08:40:06 CEST 2020

0crat · 2020-04-03T06:57:26Z

Job #329 is not in the agenda of @amihaiemil /z, can't set title

0crat · 2020-04-03T06:58:43Z

Job was finished in 10 hours, bonus for fast delivery is possible (see §36)

ry99 added 2 commits April 2, 2020 14:43

added container.wait()

00f57ba

use URIBuilder, add return value

8591519

0crat added scope role/REV labels Apr 2, 2020

amihaiemil requested changes Apr 2, 2020

View reviewed changes

src/main/java/com/amihaiemil/docker/Container.java Show resolved Hide resolved

src/main/java/com/amihaiemil/docker/RtContainer.java Outdated Show resolved Hide resolved

amihaiemil self-assigned this Apr 2, 2020

ry99 added 2 commits April 2, 2020 17:40

added test case

5a6b1cc

removed json header

a6d3667

rultor merged commit a6d3667 into amihaiemil:master Apr 3, 2020

0crat removed the scope label Apr 3, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Add call to container/{id}/wait #329

Add call to container/{id}/wait #329

Uh oh!

ry99 commented Apr 2, 2020

Uh oh!

amihaiemil commented Apr 2, 2020

Uh oh!

amihaiemil left a comment

Uh oh!

Uh oh!

Uh oh!

0crat commented Apr 2, 2020

Uh oh!

amihaiemil commented Apr 3, 2020

Uh oh!

rultor commented Apr 3, 2020

Uh oh!

rultor commented Apr 3, 2020

Uh oh!

amihaiemil commented Apr 3, 2020

Uh oh!

amihaiemil commented Apr 3, 2020

Uh oh!

rultor commented Apr 3, 2020

Uh oh!

rultor commented Apr 3, 2020

Uh oh!

0crat commented Apr 3, 2020

Uh oh!

0crat commented Apr 3, 2020

Uh oh!

Uh oh!

Uh oh!

Add call to container/{id}/wait #329

Add call to container/{id}/wait #329

Uh oh!

Conversation

ry99 commented Apr 2, 2020

Uh oh!

amihaiemil commented Apr 2, 2020

Uh oh!

amihaiemil left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

0crat commented Apr 2, 2020

Uh oh!

amihaiemil commented Apr 3, 2020

Uh oh!

rultor commented Apr 3, 2020

Uh oh!

rultor commented Apr 3, 2020

Uh oh!

amihaiemil commented Apr 3, 2020

Uh oh!

amihaiemil commented Apr 3, 2020

Uh oh!

rultor commented Apr 3, 2020

Uh oh!

rultor commented Apr 3, 2020

Uh oh!

0crat commented Apr 3, 2020

Uh oh!

0crat commented Apr 3, 2020

Uh oh!

Uh oh!