perf check #698
perf check #698
Conversation
|
|
...layout/constraintlayout/src/main/java/androidx/constraintlayout/widget/ConstraintLayout.java
Outdated
Show resolved
Hide resolved
...traintlayout/src/main/java/androidx/constraintlayout/widget/ConstraintLayoutPerformance.java
Show resolved
Hide resolved
constraintlayout/core/src/main/java/androidx/constraintlayout/core/LinearSystem.java
Outdated
Show resolved
Hide resolved
...outVerification/app/src/main/java/android/support/constraint/app/CheckPerformanceMetric.java
Outdated
Show resolved
Hide resolved
constraintlayout/core/src/main/java/androidx/constraintlayout/core/Metrics.java
Outdated
Show resolved
Hide resolved
| case NUMBER_OF_CHILD_VIEWS: | ||
| return "ChildCount"; | ||
| case NUMBER_OF_CHILD_MEASURES: | ||
| return "ChildrenMeasures"; |
There was a problem hiding this comment.
nit: I am not sure if this is for the number of measures calls made by children. If so, maybe we could name it ChildrenMeasuresCalls, or NumberOfMeasures to match line 216, or WidgetsMeasuresCalls to match DURATION_OF_CHILD_MEASURES.
There was a problem hiding this comment.
One is the
A. Number of times ConstraintLayout called child.measure()
number of calls to child measure or number of child.measure()'s
The other is
B. The time spend in children doing measure.
or duration spent in children.measure()
"Child Measures Calls" implies the children called measure. They might because they might have children but we do not measure that.
Children have a method measure() which ConstraintLayout called
The Child spends time in Measure.
Anyway it was intentional
There was a problem hiding this comment.
Makes sense. Thanks for the explanation!
No description provided.