MediaSession.setSessionActivity prevents unsetting Activity

[bubenheimer]

Version

Media3 1.5.1

More version details

No response

Devices that reproduce the issue

N/A

Devices that do not reproduce the issue

No response

Reproducible in the demo app?

Yes

Reproduction steps

MediaSession.setSessionActivity(PendingIntent) does not accept null. This prevents unsetting the session Activity when it is no longer valid. The best I can do is cancel the PendingIntent.

MediaSession.Builder does not require setting a session Activity. Why does setSessionActivity attempt to prevent this?

In my use case I have a long-lived media session transcending major changes in app state.

Expected result

N/A

Actual result

N/A

Media

N/A

Bug Report

• You will email the zip file produced by adb bugreport to [email protected] after filing this issue.

[marcbaechinger]

Thanks for your report!

MediaSessionCompat.setSessionActivity(PendingIntent pi) is @ NonNull which is probably where this is coming from.

However, I agree we should allow to reset the PendingIntent to null for convenience and because the platform version of the method allows to set null.

[bubenheimer]

I also have the impression that media3's setSessionActivity does not sufficiently account for concurrent access.