Skip to content

Commit 2fb6834

Browse files
authored
Replace deprecated module and operator in example_tasks.py (#13527)
- `from airflow.utils.helpers import chain` to `from airflow.models.baseoperator import chain` This commit also adds Bowler refactor for backport packages
1 parent 8ab964e commit 2fb6834

File tree

2 files changed

+14
-1
lines changed

2 files changed

+14
-1
lines changed

airflow/providers/google/cloud/example_dags/example_tasks.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
from google.protobuf import timestamp_pb2
3030

3131
from airflow import models
32+
from airflow.models.baseoperator import chain
3233
from airflow.operators.bash import BashOperator
3334
from airflow.providers.google.cloud.operators.tasks import (
3435
CloudTasksQueueCreateOperator,
@@ -46,7 +47,6 @@
4647
CloudTasksTasksListOperator,
4748
)
4849
from airflow.utils.dates import days_ago
49-
from airflow.utils.helpers import chain
5050

5151
timestamp = timestamp_pb2.Timestamp()
5252
timestamp.FromDatetime(datetime.now() + timedelta(hours=12)) # pylint: disable=no-member

dev/provider_packages/refactor_provider_packages.py

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -627,6 +627,13 @@ def pure_airflow_models_filter(node: LN, capture: Capture, filename: Filename) -
627627
"""Check if select is exactly [airflow, . , models]"""
628628
return len(list(node.children[1].leaves())) == 3
629629

630+
def _contains_chain_in_import_filter(node: LN, capture: Capture, filename: Filename) -> bool:
631+
if "module_import" in capture:
632+
return bool("chain" in capture["module_import"].value) and filename.startswith(
633+
"./airflow/providers/google/"
634+
)
635+
return False
636+
630637
os.makedirs(
631638
os.path.join(get_target_providers_package_folder("google"), "common", "utils"), exist_ok=True
632639
)
@@ -668,6 +675,12 @@ def pure_airflow_models_filter(node: LN, capture: Capture, filename: Filename) -
668675
.rename("airflow.providers.google.common.utils.process_utils")
669676
)
670677

678+
(
679+
self.qry.select_module("airflow.models.baseoperator")
680+
.filter(callback=_contains_chain_in_import_filter)
681+
.rename("airflow.providers.google.common.utils.helpers")
682+
)
683+
671684
(
672685
self.qry.select_module("airflow.utils.helpers")
673686
.filter(callback=google_package_filter)

0 commit comments

Comments
 (0)