Fix few typos, stale README.md and include clean up code when needed#448
Merged
karanvasnani merged 5 commits intoaws:mainfrom Sep 23, 2021
suniltheta:few_readme_docs_typo_fix
Merged
Fix few typos, stale README.md and include clean up code when needed#448karanvasnani merged 5 commits intoaws:mainfrom suniltheta:few_readme_docs_typo_fix
karanvasnani merged 5 commits intoaws:mainfrom
suniltheta:few_readme_docs_typo_fix
Conversation
suniltheta
commented
Sep 8, 2021
| fi | ||
| } | ||
|
|
||
| describe_create_ecr_registry() { |
Author
There was a problem hiding this comment.
This will create the registry if it doesn't exist already. Otherwise we would try to upload the file and just fail instead.
suniltheta
commented
Sep 8, 2021
| ```bash | ||
| # Your AWS account ID | ||
| export AWS_ACCOUNT_ID=999999999999 | ||
| export AWS_ACCOUNT_ID=<YOUR AWS ACCOUNT ID> |
Author
There was a problem hiding this comment.
git didn't let me commit without this change. It thought this was a secret that I am committing. I could have done git commit --no-verify. But anyway.
suniltheta
commented
Sep 8, 2021
| Target: | ||
| VirtualService: | ||
| VirtualServiceName: !GetAtt ColorTellerService.VirtualNodeName | ||
| VirtualServiceName: !GetAtt ColorTellerService.VirtualServiceName |
karanvasnani
approved these changes
Sep 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix few typos, stale README.md and include clean up code when needed
Also fix #421
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.