Skip to content

Python: Format with black and switch superlint #5513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 18, 2023
Merged

Python: Format with black and switch superlint #5513

merged 3 commits into from
Oct 18, 2023

Conversation

DavidSouther
Copy link
Contributor

This pull request reformats Python examples with black, and enables the Black in super lint. It's FYI for @rlhagerm and @ford-at-aws.

Part of #5510

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added Python This issue relates to the AWS SDK for Python (boto3) GitHub settings This affects GitHub settings labels Oct 16, 2023
@rlhagerm
Copy link
Contributor

@ford-at-aws , you're more experienced with this formatter, so I'll defer to your approval. My only suggestion is a sanity check to ensure the tests in the folder pass before and after.

@DavidSouther DavidSouther marked this pull request as draft October 16, 2023 19:35
@ford-at-aws ford-at-aws marked this pull request as ready for review October 17, 2023 15:25
ford-at-aws
ford-at-aws approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@ford-at-aws ford-at-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, sanity check passed

ford-at-aws
ford-at-aws previously requested changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@ford-at-aws ford-at-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself looks great; however, talked w/ team and we need to NOT merge this until linting fixes have been validated.

@DavidSouther DavidSouther added On Call Review needed This work needs an on-call review Text Review not needed This contains no text which needs review labels Oct 17, 2023
@DavidSouther
Copy link
Contributor Author

@ford-at-aws Looks like it works - super lint logs that it ran black on all the files!

@cpyle0819 cpyle0819 dismissed ford-at-aws’s stale review October 18, 2023 17:13

Comment addressed

@cpyle0819 cpyle0819 added On Call Review complete On call review complete and removed On Call Review needed This work needs an on-call review labels Oct 18, 2023
@cpyle0819 cpyle0819 merged commit afb3309 into awsdocs:main Oct 18, 2023
@DavidSouther DavidSouther deleted the python/black branch October 23, 2023 15:25
@rlhagerm rlhagerm mentioned this pull request Oct 30, 2023
Closed
ford-at-aws pushed a commit that referenced this pull request Dec 15, 2023
@DavidSouther @ford-at-aws
Python: Format with black and switch superlint (#5513)
9983b9b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpyle0819 cpyle0819 cpyle0819 approved these changes

@ford-at-aws ford-at-aws Awaiting requested review from ford-at-aws

Assignees

@DavidSouther DavidSouther

Labels
GitHub settings This affects GitHub settings On Call Review complete On call review complete Python This issue relates to the AWS SDK for Python (boto3) Text Review not needed This contains no text which needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DavidSouther @rlhagerm @cpyle0819 @ford-at-aws