Skip to content

Public Cloud: Change table format #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
k-dimple opened this issue Apr 5, 2024 · 4 comments · Fixed by canonical/ubuntu-cloud-docs#208
Closed

Public Cloud: Change table format #51

k-dimple opened this issue Apr 5, 2024 · 4 comments · Fixed by canonical/ubuntu-cloud-docs#208
Assignees
Labels
edit Edit pre-existing documentation for consistency, style and application good first issue An ideal task to start with size 1 Fix a known documentation issue (size 1/8)

Comments

@k-dimple
Copy link
Collaborator

k-dimple commented Apr 5, 2024

GitHub repo: https://github.com/canonical/ubuntu-cloud-docs

The tables on this page consists of two columns each ('Kind', URN'). Convert them into 3 columns each with titles: 'Architecture', 'Hyper-V Generation' and 'URN'.

@k-dimple k-dimple added good first issue An ideal task to start with edit Edit pre-existing documentation for consistency, style and application size 1 Fix a known documentation issue (size 1/8) labels Apr 5, 2024
@krzysiekwie
Copy link
Contributor

Happy to try this as my first issue here, I can get this done within a day from assignment

@k-dimple
Copy link
Collaborator Author

k-dimple commented Apr 7, 2024

Hello @krzysiekwie! Thanks, please go ahead and try it. I've assigned it to you.

@krzysiekwie
Copy link
Contributor

Hi @k-dimple I added the basic edit in canonical/ubuntu-cloud-docs#206
(don't think I can use fixes #51 directly on ubuntu-cloud-docs).

Also I'm not sure if the first two columns should get cenetered. Github and my local rst preview does not render centering. I tried the three formats from:
https://github.com/krzysiekwie/ubuntu-cloud-docs/blob/change-formatting/doc-cheat-sheet-myst.md
in
https://github.com/krzysiekwie/ubuntu-cloud-docs/blob/change-formatting/azure/azure-how-to/instances/find-ubuntu-images.rst

Let me know what you think.

@k-dimple
Copy link
Collaborator Author

k-dimple commented Apr 8, 2024

Hi @krzysiekwie, adding the edit directly in the repo is perfectly fine. I have put in a comment there.

Regarding the centring, I don't think we need to centre the first two columns. It looks better left-aligned.
Using ":align: center" works for the whole table. Currently, I don't think there's an option to centre only certain columns using list-tables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
edit Edit pre-existing documentation for consistency, style and application good first issue An ideal task to start with size 1 Fix a known documentation issue (size 1/8)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants