Don't use reflection to call Iterable.collectionClassName #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f599bb8 to
796775f
Compare
|
Thanks for your effort! Are there plan to merge this? I would be helpful to use this lib in native images. |
This is an issue on GraalVM, where all collection concrete classes would need to be added to some Graal reflection config for collectionClassName to be call-able by reflection.
796775f to
b736b36
Compare
|
@lolgab Great stuff, thanks for merging. I just tested and it works in native environments now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the calls to
Iterable.collectionClassNamemore "standard", that is not reflection-based.Reflection is an issue on GraalVM native-image, where all collection concrete classes would need to be added to some Graal reflection config for
collectionClassNameto be call-able by reflection.