CXXCBC-142: Update SRV resolution for Windows#303
Merged
avsej merged 1 commit intocouchbase:mainfrom Oct 30, 2022
Merged
Conversation
Contributor
Author
|
ugh -- I will try to workout the Windows build. Wasn't using VS2019 (was using VS2022). |
avsej
approved these changes
Oct 28, 2022
avsej
requested changes
Oct 28, 2022
Member
avsej
left a comment
There was a problem hiding this comment.
Right, code looks good, just failing to build on other windows platform.
9953857 to
6fc4ca2
Compare
6fc4ca2 to
a6ef3ee
Compare
avsej
approved these changes
Oct 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.