Skip to content

RCBC-453: Support history retention in collection and bucket management #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 15, 2023
Merged

RCBC-453: Support history retention in collection and bucket management #119

merged 4 commits into from
Sep 15, 2023

Conversation

DemetrisChr
Copy link
Contributor

@DemetrisChr DemetrisChr commented Sep 14, 2023 •
edited
Loading

Changes

  • Added CreateCollectionSettings, UpdateCollectionSettings
  • Support new signatures for create_collection and drop_collection to conform to the latest RFC spec (taking scope_name, collection_name, and a CreateCollectionSettings instance (in the case of create_collection), instead of a CollectionSpec instance)
  • Deprecated passing a CollectionSpec to create_collection and drop_collection
  • Added update_collection
  • Support all history retention settings in BucketSettings, CreateCollectionSettings and UpdateCollectionSettings
  • Added tests for bucket and collection management
  • Added some test helpers for retrying operations
  • C++ core update

Results

All tests pass

@DemetrisChr DemetrisChr requested a review from avsej September 14, 2023 10:42
@cb-sdk-robot
Copy link
Collaborator

Can one of the admins verify this patch?

@DemetrisChr DemetrisChr changed the title RCBC-454: Support history retention in collection and bucket management RCBC-453: Support history retention in collection and bucket management Sep 14, 2023
@DemetrisChr DemetrisChr merged commit d23002b into couchbase:main Sep 15, 2023
@DemetrisChr DemetrisChr deleted the RCBC-454-dedup branch September 15, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avsej avsej avsej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DemetrisChr @cb-sdk-robot @avsej