Skip to content

RCBC-427: Add missing query idx management options & use InvalidArgument error #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 18, 2023
Merged

RCBC-427: Add missing query idx management options & use InvalidArgument error #92

merged 3 commits into from
Apr 18, 2023

Conversation

DemetrisChr
Copy link
Contributor

  • Added scope_name and collection_name to the options for get_all_indexes, build_deferred_indexes and `watch_indexes
  • Added index_name to the options for create_primary_index
  • Replaced ArgumentErrors in query index management operations with Error::InvalidArgument errors
  • Use the core API for build_deferred_indexes

@cb-sdk-robot
Copy link
Collaborator

Can one of the admins verify this patch?

@DemetrisChr DemetrisChr requested a review from avsej April 18, 2023 13:06
@DemetrisChr DemetrisChr changed the title Query index management fixes Add missing query idx management options & use InvalidArgument error Apr 18, 2023
@DemetrisChr DemetrisChr changed the title Add missing query idx management options & use InvalidArgument error RCBC-427: Add missing query idx management options & use InvalidArgument error Apr 18, 2023
@DemetrisChr DemetrisChr merged commit 32a0c2e into couchbase:main Apr 18, 2023
@DemetrisChr DemetrisChr deleted the query-idx-fixes branch April 18, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avsej avsej avsej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DemetrisChr @cb-sdk-robot @avsej