CXXCBC-54 Add log forwarding #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation ========== When the client is used in the sdk wrappers (python, node, etc...), it would be nice to allow the logging to be forwarded to the wrapper's logging handlers. Modification ============ Simplest thing to do is add a spdlog::sinks::sink to the logger configuration. If it is set, we add it. Then the wrappers can implement a sink that does the handoff. Results ======= I didn't add tests, as there are no logging tests anyways. I did for the transactions logging, and I've used this in python.
avsej
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When the client is used in the sdk wrappers (python, node, etc...), it
would be nice to allow the logging to be forwarded to the wrapper's
logging handlers.
Modification
Simplest thing to do is add a spdlog::sinks::sink to the logger
configuration. If it is set, we add it. Then the wrappers can
implement a sink that does the handoff.
Results
I didn't add tests, as there are no logging tests anyways. I did for
the transactions logging, and I've used this in python.