CXXCBC-55: External Tracing and Metrics support #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation ========== Allow clients to plug in their own tracing and/or metrics solutions, such as OpenTelemetry Modifications ============= Expose the tracer and meter in cluster_options. Then, add a parent_span to many (but for now, not all) requests. The tests use a simple tracer and meter implementation to facilitate testing. *** Will update this with a header that wraps OpenTelemetry objects in particular, which will not be referenced by anything in the client so we will only require otel when it is used. Results ======= Tests pass
|
@davidkelly looks like Jenkins failures are legit and related to tracer and meter: |
avsej
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Allow clients to plug in their own tracing and/or metrics solutions,
such as OpenTelemetry
Modifications
Expose the tracer and meter in cluster_options. Then, add a parent_span
to many (but for now, not all) requests. The tests use a simple tracer
and meter implementation to facilitate testing.
*** Will update this with a header that wraps OpenTelemetry objects in
particular, which will not be referenced by anything in the client so we
will only require otel when it is used.
Results
Tests pass