Skip to content

CXXCBC-142: Update SRV resolution for Windows #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2022
Merged

CXXCBC-142: Update SRV resolution for Windows #303

merged 1 commit into from
Oct 30, 2022

Conversation

thejcfactor
Copy link
Contributor

No description provided.

@thejcfactor thejcfactor requested review from avsej, davidkelly and a team October 27, 2022 21:41
@thejcfactor
Copy link
Contributor Author

ugh -- I will try to workout the Windows build. Wasn't using VS2019 (was using VS2022).

avsej
avsej requested changes Oct 28, 2022
View reviewed changes
Copy link
Member

@avsej avsej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, code looks good, just failing to build on other windows platform.

@thejcfactor thejcfactor force-pushed the CXXCBC-142 branch 2 times, most recently from 9953857 to 6fc4ca2 Compare October 28, 2022 23:40
@thejcfactor thejcfactor requested a review from avsej October 29, 2022 01:00
@avsej avsej merged commit 2d8d82d into couchbase:main Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avsej avsej avsej approved these changes

@davidkelly davidkelly Awaiting requested review from davidkelly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thejcfactor @avsej