Skip to content

CXXCBC-401: Add ping & diagnostics to public API #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

DemetrisChr
Copy link
Contributor

Motivation

The ping and diagnostics operations currently only exist in the Core API, they also need to be exposed in the Public API

Changes

  • Add ping() to public Cluster and Bucket APIs
  • Add diagnostics() to the public Cluster` API
  • Add any relevant options & results to Public API (diagnostics_options, ping_options, diagnostics_result, ping_result, endpoint_diagnostics, endpoint_ping_report, service_type, ping_state, endpoint_state)
  • Add tests (the public API equivalents of the existing core diagnostics tests)
  • Moved the existing core diagnostics unit tests to a file separate from the integration tests

Results

All tests pass

@DemetrisChr DemetrisChr force-pushed the CXXCBC-401-public-diagnostics branch 2 times, most recently from a8a4340 to 733d1d0 Compare December 20, 2023 18:35
@DemetrisChr DemetrisChr requested a review from avsej December 20, 2023 18:46
@DemetrisChr DemetrisChr force-pushed the CXXCBC-401-public-diagnostics branch from 733d1d0 to 54e6316 Compare December 20, 2023 18:53
@DemetrisChr DemetrisChr force-pushed the CXXCBC-401-public-diagnostics branch from 54e6316 to 6d0c970 Compare December 21, 2023 13:46
@avsej avsej merged commit b41a7e0 into couchbase:main Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants