CXXCBC-461: Do not send ping to nodes that have not completed bootstrap. #540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If doing a ping during a rebalance of a multi-node cluster it is possible that one or more of the nodes are in the process of completing bootstrap. This can cause the ping operation to timeout. Since we know when a node has bootstrapped or not, the SDK should not ping a node that has not bootstrapped. This will allow for the ping operation to complete without the worry of a timeout due to waiting on the bootstrap process to successfully complete. * Add a mechanism to keep track of the last error w/in the `bootstrap_handler`. * If ping is called, check if the node has bootstrapped. If the node is not bootstrapped, add the kv node to the ping report with an error indicating either the last error message from the `bootstrap_handler` or a generic message, but do not execute the ping operation.
avsej
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If doing a ping during a rebalance of a multi-node cluster it is possible that one or more of the nodes are in the process of completing bootstrap. This can cause the ping operation to timeout. Since we know when a node has bootstrapped or not, the SDK should not ping a node that has not bootstrapped. This will allow for the ping operation to complete without the worry of a timeout due to waiting on the bootstrap process to successfully complete.
bootstrap_handler.bootstrap_handleror a generic message, but do not execute the ping operation.