Skip to content

fix(storage): bloom filter is using wrong cache key #9706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2023

Conversation

sundy-li
Copy link
Member

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR

This is a bug introduced in #9672

BTW, the metric name should be lower case, PTAL @dantengsky

+--------------------------------------------------------------+-------+--------+---------+                                                                                                                                  [245/98410]
| metric                                                       | kind  | labels | value   |
+--------------------------------------------------------------+-------+--------+---------+
| cache_BLOOM_INDEX_DATA_CACHE_access_count                    | gauge | {}     | 6048.0  |
| cache_BLOOM_INDEX_DATA_CACHE_miss_count                      | gauge | {}     | 6048.0  |
| cache_BLOOM_INDEX_DATA_CACHE_miss_load_millisecond           | gauge | {}     | 872.0   |
| cache_BLOOM_INDEX_FILE_META_DATA_CACHE_access_count          | gauge | {}     | 6048.0  |

Closes #issue

@vercel
Copy link

vercel bot commented Jan 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
databend ⬜️ Ignored (Inspect) Jan 22, 2023 at 3:25PM (UTC)

@sundy-li sundy-li requested a review from dantengsky January 22, 2023 15:25
@mergify mergify bot added the pr-bugfix this PR patches a bug in codebase label Jan 22, 2023
@dantengsky
Copy link
Member

BTW, the metric name should be lower case, PTAL @dantengsky

let me take care of this

@BohuTANG BohuTANG merged commit fdff328 into databendlabs:main Jan 22, 2023
@dantengsky
Copy link
Member

BTW, the metric name should be lower case, PTAL @dantengsky

let me take care of this

addressed by @BohuTANG in #9742

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants