feat(sql): eliminate extra group by scalars

[sundy-li]

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR

eliminate extra group-by scalars

continue #9678
Closes #9611

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated
databend	⬜️ Ignored (Inspect)			Jan 23, 2023 at 7:25AM (UTC)

[BohuTANG]

Run cargo fmt --all -- --check
Diff in /workspace/src/query/sql/src/planner/binder/aggregate.rs at line 327:
             } = expr
             {
                 let (scalar, alias) = Self::resolve_index_item(expr, *index, select_list)?;
-                
+
                 // If group by scalar is a constant literal, we can skip it.
                 if matches!(scalar, ScalarExpr::ConstantExpr(_)) {
                     continue;
Diff in /workspace/src/query/sql/src/planner/binder/aggregate.rs at line 334:
                 }
-                
+
                 let key = format!("{:?}", &scalar);
                 if let Entry::Vacant(entry) = bind_context.aggregate_info.group_items_map.entry(key)
                 {
Diff in /workspace/src/query/sql/src/planner/binder/select.rs at line 101:
             .await?;
 
         let (mut scalar_items, projections) = self.analyze_projection(&select_list)?;
-        
+
         // This will potentially add some alias group items to `from_context` if find some.
         self.analyze_group_items(&mut from_context, &select_list, &stmt.group_by)
             .await?;
Diff in /workspace/src/query/sql/src/planner/binder/select.rs at line 127:
             )
             .await?;
 
-        if !from_context.aggregate_info.aggregate_functions.is_empty() || !from_context.aggregate_info.group_items.is_empty()
+        if !from_context.aggregate_info.aggregate_functions.is_empty()
+            || !from_context.aggregate_info.group_items.is_empty()
         {
             s_expr = self.bind_aggregate(&mut from_context, s_expr).await?;
         }